Fix default color of mne.viz.Brain.add_text #12470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmvanvliet
requested review from
agramfort,
dengemann and
drammock
as code owners
drammock
approved these changes
Mar 1, 2024
Member
|
Thanks @wmvanvliet ! |
larsoner
added a commit
to vpKumaravel/mne-python
that referenced
this pull request
Mar 1, 2024
* upstream/main: Fix default color of mne.viz.Brain.add_text (mne-tools#12470)
snwnde
pushed a commit
to snwnde/mne-python
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I guess this got lost at some point.
mne.viz.Brain.add_textshould by default use_fg_colorfor the color of the text, but didn't and defaulted to always be black, even when the background color of the figure is black.