Skip to content

Fix default color of mne.viz.Brain.add_text #12470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsoner merged 2 commits into from
Mar 1, 2024
Merged

Fix default color of mne.viz.Brain.add_text #12470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b8830a
Fix default color of mne.viz.Brain.add_text
wmvanvliet Mar 1, 2024
309a69f
Add what's new
wmvanvliet Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/devel/12470.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- Fix the default color of :meth:`mne.viz.Brain.add_text` to properly contrast with the figure background color, by `Marijn van Vliet`_.
2 changes: 2 additions & 0 deletions mne/viz/_brain/_brain.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2917,6 +2917,8 @@ def add_text(
name = text if name is None else name
if "text" in self._actors and name in self._actors["text"]:
raise ValueError(f"Text with the name {name} already exists")
if color is None:
color = self._fg_color
for ri, ci, _ in self._iter_views("vol"):
if (row is None or row == ri) and (col is None or col == ci):
actor = self._renderer.text2d(
Expand Down