-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Use SI units for eyetracking data, update tutorials #12846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
When setting scalings, I matched the scalings used for other channels of the same type: - eyegaze == fnirs_df_phase == radians - pupil == hbo/hbr == meters
|
Ok here is the built documentation for the Eyetracking tutorials. Marking as ready for review! |
| custom_scalings = dict(pupil=1e3) | ||
| raw.pick(picks="eyetrack").plot(scalings=custom_scalings) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @larsoner Im not sure what you mean by setting the units and if you are referring to the eyegaze channel or pupil channel (I assume eyegaze) - Can you clarify?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant for plot_raw but I see now that we only have it for other viz functions like plot_evoked, so never mind! Also not sure it would actually help...
|
Thanks @scott-huberty ! |
|
looking a bit late, but why is the unit for pupil |
|
Ugh yes that seems like a bug... |

closes #12756
Updated
mne.defaultsso that eyegaze channels are expected to be radians and pupil size channels are expected to be meters. When specifying the scalings, I matched the scalings with other MNE channel types that have a radians/meters unit (e.g. fnirs_fd_phase for radians, hbo/hbr for meters).Updated the eyetracking tutorials such that eygaze units are converted to radians as early as possible.
Notable exceptions: