Adjust Pupil channel units (again) #13314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13244
There have been several iterations on the issue of eyetracking units, so let me summarize for brevity:
Stemming from Issue #12756 (comment) (and PR #12846 (comment) + #12850), we changed MNE internals to assume all incoming Eyetracking data were already represented in Meters (SI unit of distance, as some eyetrackers report pupil size in mm). In those PR's I adjusted the scaling for Pupil channels so that data in meters would look nice when plotting by default. I chose a scaling factor of 1e6 (meters -> micro meters).
This caused
inst.to_data_frame()to convert from meters -> micrometers which is probably not very intuitive for researchers (hence #13244).It is probably more intuitive to adjust the scalings to go from meters to mm. The plotting still looks good, and pupil channels will be converted to mm by default by
to_data_frame():Does this sound reasonable to you @larsoner and @drammock ?