Skip to content

Adjust Pupil channel units (again) #13314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsoner merged 2 commits into from
Jul 11, 2025
Merged

Adjust Pupil channel units (again) #13314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ae9fec
Since we store pupils in meters. Scale pupil data for mm
scott-huberty Jul 11, 2025
45d21d1
DOC: update changelog
scott-huberty Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/devel/13314.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Change default pupil unit scalings from micrometrs to millimeters by `Scott Huberty`_
4 changes: 2 additions & 2 deletions mne/defaults.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
gsr="S",
temperature="C",
eyegaze="rad",
pupil="µm",
pupil="mm",
),
# scalings for the units
scalings=dict(
Expand Down Expand Up @@ -122,7 +122,7 @@
gsr=1.0,
temperature=1.0,
eyegaze=1.0,
pupil=1e6,
pupil=1e3,
),
# rough guess for a good plot
scalings_plot_raw=dict(
Expand Down