FIX: DigMontage.rename_channels should return self #13320
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sappelhoff
requested review from
agramfort,
dengemann,
drammock,
jasmainak,
larsoner and
mscheltienne
as code owners
larsoner
approved these changes
Jul 15, 2025
Member
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
About to cut a release but I think I can sneak this in (will have to push a commit or two after a merge), thanks in advance @sappelhoff !
* upstream/main: MAINT: Prep for release (mne-tools#13319)
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Jul 23, 2025
* upstream: (115 commits) Capitalize Get Help (mne-tools#13340) Website page load fixes (mostly) (mne-tools#13343) MAINT: Restore statsmodels to pip-pre (mne-tools#13345) BUG: Fix bug with reading old reports (mne-tools#13341) [pre-commit.ci] pre-commit autoupdate (mne-tools#13338) MAINT: Fix ref cycle with vtkPolyData (mne-tools#13336) MAINT: Dont set private attributes for PyVista Actor (mne-tools#13334) Add icon links to our donation pages (mne-tools#13331) MAINT: Dont set attribute on PolyData (mne-tools#13330) MAINT: Bump mins, deprecations (mne-tools#13322) Fix changes in SSD for backward compatibility [circle deploy] (mne-tools#13327) ENH: Add GED transformer (mne-tools#13259) FIX: Links MAINT: Stabilize MxNE tests (mne-tools#13321) FIX: DigMontage.rename_channels should return self (mne-tools#13320) MAINT: Prep for release (mne-tools#13319) [pre-commit.ci] pre-commit autoupdate (mne-tools#13317) MAINT: Update code credit (mne-tools#13318) MAINT: Make MxNE test more robust (mne-tools#13315) Adjust Pupil channel units (again) (mne-tools#13314) ...
WouterKroot
pushed a commit
to WouterKroot/mne-python
that referenced
this pull request
Aug 13, 2025
zEdS15B3GCwq
pushed a commit
to zEdS15B3GCwq/mne-python
that referenced
this pull request
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix to be in accordance with what the docstr advertises. https://mne.tools/stable/generated/mne.channels.DigMontage.html#mne.channels.DigMontage.rename_channels