Website page load fixes (mostly) #13343
Conversation
| <li><a href="{{ pathto('auto_tutorials/index.html', 1) }}"><i class="fas fa-book fa-fw"></i> Tutorials</a></li> | ||
| <li><a href="{{ pathto('development/whats_new.html', 1) }}"><i class="fas fa-newspaper fa-fw"></i> Changelog</a></li> | ||
| <li><a href="{{ pathto('help/index.html', 1) }}"><i class="fas fa-circle-question fa-fw"></i> Get help</a></li> | ||
| <li><a href="{{ pathto('help/index.html', 1) }}"><i class="fas fa-circle-question fa-fw"></i> Get Help</a></li> |
There was a problem hiding this comment.
capitalize H in "Get Help" (somebody requested this)
| copyright = ( # noqa: A001 | ||
| f'2012–{td.year}, MNE Developers. Last updated <time datetime="{td.isoformat()}" class="localized">{td.strftime("%Y-%m-%d %H:%M %Z")}</time>\n' # noqa: E501 | ||
| '<script type="text/javascript">$(function () { $("time.localized").each(function () { var el = $(this); el.text(new Date(el.attr("datetime")).toLocaleString([], {dateStyle: "medium", timeStyle: "long"})); }); } )</script>' # noqa: E501 | ||
| '<script type="text/javascript">function formatTimestamp() {document.querySelectorAll("time.localized").forEach(el => el.textContent = new Date(el.getAttribute("datetime")).toLocaleString([], {dateStyle: "medium", timeStyle: "long"}));};if (document.readyState != "loading") formatTimestamp();else document.addEventListener("DOMContentLoaded", formatTimestamp);</script>' # noqa: E501 |
There was a problem hiding this comment.
purge JQuery from timestamp localizer script (wasn't working because $ not defined; we don't have globally available JQuery anymore)
| # further. For a list of options available for each theme, see the | ||
| # documentation. | ||
| switcher_version_match = "dev" if ".dev" in version else version | ||
| switcher_version_match = "dev" if ".dev" in release else version |
There was a problem hiding this comment.
not sure when this changed / stopped working, but above, version is defined as X.Y and release is the full __version__ string (incl. the .devZZZZZZZ part, if present)
|
Note that there are still page-load errors in the browser console, but they're bubbling up from bootstrap we only use bootstrap in our reports, but it comes via Webpack from PyData Sphinx Theme. Strangely, I don't see those errors on the theme's own website, not sure why not. |
|
version switcher is working: 
Also the capitalization: 
and the localization of the last-built timestamp: 
So I'll mark for merge-when-green |
|
Great, thanks @drammock ! |
|
@drammock the change in #13340 is still required, because it affects the navbar menu entry. You only changed the sidebar entry here: 
Also, can we talk about using "dev" instead of "devel" for our development version? "dev" is much more common nowadays, "devel" is primarily used for Debian package naming. Basically all Python projects use "dev" (e.g., NumPy, pandas, Scikit-Learn, Matplotlib, Bokeh, ...). |
|
Very nice, thank you, @drammock |
* upstream: (115 commits) Capitalize Get Help (mne-tools#13340) Website page load fixes (mostly) (mne-tools#13343) MAINT: Restore statsmodels to pip-pre (mne-tools#13345) BUG: Fix bug with reading old reports (mne-tools#13341) [pre-commit.ci] pre-commit autoupdate (mne-tools#13338) MAINT: Fix ref cycle with vtkPolyData (mne-tools#13336) MAINT: Dont set private attributes for PyVista Actor (mne-tools#13334) Add icon links to our donation pages (mne-tools#13331) MAINT: Dont set attribute on PolyData (mne-tools#13330) MAINT: Bump mins, deprecations (mne-tools#13322) Fix changes in SSD for backward compatibility [circle deploy] (mne-tools#13327) ENH: Add GED transformer (mne-tools#13259) FIX: Links MAINT: Stabilize MxNE tests (mne-tools#13321) FIX: DigMontage.rename_channels should return self (mne-tools#13320) MAINT: Prep for release (mne-tools#13319) [pre-commit.ci] pre-commit autoupdate (mne-tools#13317) MAINT: Update code credit (mne-tools#13318) MAINT: Make MxNE test more robust (mne-tools#13315) Adjust Pupil channel units (again) (mne-tools#13314) ...
4 participants
closes #12558
closes #13340 (supersedes; that PR is fixing it in the wrong place)
WIP; fixing the jquery pageload errors first, so that we can hopefully see the version switcher errors surface.