Changed epochs_clean_sub = model_plain.apply(epochs) to epochs_clean_sub = model_sub.apply(epochs), making use of the regression coefficients from model_sub. #12977 #12978
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sub = model_sub.apply(epochs), making use of the regression coefficients from model_sub.
JacPhe
requested review from
agramfort,
dengemann and
drammock
as code owners
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
Contributor
Contributor
|
@JacPhe you are correct. That is (soon to be "was") a mistake in the tutorial. Thanks for pointing it out to us and even submitting a PR to fix it. Before I merge this, could you also add a new file and then also add your name to This way, your contribution ends up in the "What's new" list for the next release. |
JacPhe
changed the title
JacPhe
changed the title
doc/changes/devel/12978.other.rst
Outdated
| @@ -0,0 +1 @@ | |||
| Fix a mistake in :ref:`_tut-artifact-regression` where the wrong regression coefficients were applied, by :newcontrib:`Jacob Phelan`. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Fix a mistake in :ref:`_tut-artifact-regression` where the wrong regression coefficients were applied, by :newcontrib:`Jacob Phelan`. | |
| Fix a mistake in :ref:`tut-artifact-regression` where the wrong regression coefficients were applied, by :newcontrib:`Jacob Phelan`. |
I think this should fix the CI error's (as seen here )!
Contributor
sappelhoff
approved these changes
Nov 22, 2024
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
Contributor
|
Thanks @JacPhe! |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Dec 6, 2024
* upstream/main: (736 commits) ENH: Add round-trip channel name saving (mne-tools#13003) update governance (mne-tools#12896) pin selenium and stop filtering its warning (mne-tools#13000) DOC: fix return value doc of inst.get_montage() (mne-tools#12995) remove some ._filenames uses in favor of .filenames (mne-tools#12996) use eegbci.standardize instead of custom code (mne-tools#12997) Bump autofix-ci/action from dd55f44df8f7cdb7a6bf74c78677eb8acd40cd0a to ff86a557419858bb967097bfc916833f5647fa8c in the actions group (mne-tools#12999) MAINT: Update code credit (mne-tools#12998) MAINT: Unpin VTK (mne-tools#12991) [pre-commit.ci] pre-commit autoupdate (mne-tools#12988) Fix: update cnt.py to check missing annotation (mne-tools#12986) do not log about using set_montage AGAIN if it has never been used (mne-tools#12984) DOC: fix numpy docstr example Vectorizer() (mne-tools#12983) Changed epochs_clean_sub = model_plain.apply(epochs) to epochs_clean_sub = model_sub.apply(epochs), making use of the regression coefficients from model_sub. mne-tools#12977 (mne-tools#12978) DOC: add meegkit to related software suite (mne-tools#12976) DOC: specify tmax_raw param may be None, and what it means (mne-tools#12972) [pre-commit.ci] pre-commit autoupdate (mne-tools#12975) DOC: fix note in legacy pick_channels func (mne-tools#12973) Use `uint16_codec` argument (mne-tools#12971) Bump codecov/codecov-action from 4 to 5 in the actions group (mne-tools#12970) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12977
Originally, the documentation has epochs_clean_sub = model_plain.apply(epochs), which uses model_plain. This contains regression coefficients for EOG, with some bleed in from adjacent EEG sensors. I believe that it should be using epochs_clean_sub = model_sub.apply(epochs), as this makes use of model_sub, which has the regression coefficients for EOG, with a subtraction of epochs.evoked. I think this makes sense because otherwise, model_sub is completely redundant.