Skip to content

fix Maxwell bads filtering #13280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsoner merged 8 commits into from
Jun 8, 2025
+7 −1
Merged

fix Maxwell bads filtering #13280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
87007f9
init
harrisonritz May 11, 2025
2e0e1cd
remove 'include bads'
harrisonritz May 11, 2025
92bf20c
improved filtering by channel type
harrisonritz Jun 6, 2025
23ef302
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jun 6, 2025
27692fa
add changelog
harrisonritz Jun 6, 2025
ff0145f
fix changelog
harrisonritz Jun 7, 2025
fbd7fe0
fix function reference
harrisonritz Jun 7, 2025
20a2b19
remove `meg` from changelog
harrisonritz Jun 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changes/devel/13280.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed bug where :func:`mne.preprocessing.maxwell_filter_prepare_emptyroom` would not reliably identify meg channel types for matching bads across emptyroom and task, by `Harrison Ritz`_.
7 changes: 6 additions & 1 deletion mne/preprocessing/maxwell.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,12 @@ def maxwell_filter_prepare_emptyroom(
elif bads == "keep":
bads = raw_er_prepared.info["bads"]

bads = [ch_name for ch_name in bads if ch_name.startswith("MEG")]
# Filter to only include MEG channels
meg_ch_names = [
raw_er_prepared.ch_names[pick]
for pick in pick_types(raw_er_prepared.info, meg=True, exclude=[])
]
bads = [ch_name for ch_name in bads if ch_name in meg_ch_names]
raw_er_prepared.info["bads"] = bads

# handle dev_head_t
Expand Down
Loading