Skip to content

fix Maxwell bads filtering #13280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 8 commits into from
Jun 8, 2025
Merged

fix Maxwell bads filtering #13280

larsoner merged 8 commits into from
Jun 8, 2025
+7 −1

Conversation

@harrisonritz
Copy link
Contributor

@harrisonritz harrisonritz commented Jun 6, 2025

What does this implement/fix?

prepare_empty_room only includes bad channels if they are MEG channels (make sense), but it does this by looking for "MEG" in at the start of the channel name. This breaks for OPM sensors (or any sensors without this formatting).

Fixed to use pick_types instead.

@drammock
Copy link
Member

drammock commented Jun 6, 2025

LGTM, is it meant to still be draft mode? (maybe you're planning to add a test?)

@harrisonritz
Copy link
Contributor Author

harrisonritz commented Jun 6, 2025

I'm trying to use draft mode to avoid spamming you guys while I set up the PR lol.
Ready to go I think, its pretty simple to fix (but was a pain to find)

@harrisonritz harrisonritz marked this pull request as ready for review June 6, 2025 21:37
@drammock
Copy link
Member

drammock commented Jun 6, 2025

I'm trying to use draft mode to avoid spamming you guys while I set up the PR lol. Ready to go I think, its pretty simple to fix (but was a pain to find)

apparently I still get emails for new PRs even if they're draft 😅 but that's probably my own fault. thanks for keeping the spam down (or trying to at least)!

@drammock drammock enabled auto-merge (squash) June 6, 2025 21:41
auto-merge was automatically disabled June 7, 2025 17:14

Head branch was pushed to by a user without write access

@harrisonritz
Copy link
Contributor Author

harrisonritz commented Jun 8, 2025

Sorry @drammock , didn't help with spam after all, I had trouble with the changelog (the code formatting here always messes me up).
I think it should be good now. The only test that's still failing is due to time-out.

@larsoner
Copy link
Member

larsoner commented Jun 8, 2025

Would be nice to add a little test here but will merge as-is. Maybe something to add if you're feeling motivated in the next PR @harrisonritz ! 😄 Thanks for the fix

@larsoner larsoner merged commit 1926446 into mne-tools:main Jun 8, 2025
30 of 32 checks passed
larsoner added a commit to larsoner/mne-python that referenced this pull request Jun 26, 2025
@larsoner
Merge remote-tracking branch 'upstream/main' into feature/TD-nirs_snirf
63b9f35 
* upstream/main: (55 commits)
  doc: fix rendering typo rst docstr (mne-tools#13301)
  DOC: fix docstrs around layout functions (mne-tools#13300)
  MAINT: Fix doc build failure due to deprecation (mne-tools#13299)
  Birthday input cast to datetime.date (mne-tools#13284)
  DOC: fix missing space, use f-strings, structure->object (mne-tools#13291)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13290)
  ENH: channel_indices_by_type now has an exclude param (mne-tools#13293)
  Proj id and proj name access (mne-tools#13261)
  Fix: nearly invisible traces with spatial_colors=True (mne-tools#13286)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13283)
  Bump autofix-ci/action from 551dded8c6cc8a1054039c8bc0b8b48c51dfc6ef to 635ffb0c9798bd160680f18fd73371e355b85f27 in the actions group (mne-tools#13282)
  fix Maxwell bads filtering (mne-tools#13280)
  fix actionable linkcheck errors (mne-tools#13273)
  MAINT: Use radius keyword with PyVista tube (mne-tools#13277)
  BUG: Fix bug with simulating head pos and BEM (mne-tools#13276)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13274)
  MAINT: Update code credit (mne-tools#13267)
  Annotations extras (mne-tools#13228)
  Tidy up the directory reading (mne-tools#13268)
  FIX, DOC: Drop bad channel in 10_publication_figure.py (mne-tools#13266)
  ...
zEdS15B3GCwq pushed a commit to zEdS15B3GCwq/mne-python that referenced this pull request Aug 25, 2025
@harrisonritz @pre-commit-ci @zEdS15B3GCwq
fix Maxwell bads filtering (mne-tools#13280)
db96adc 
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drammock drammock drammock approved these changes

@larsoner larsoner Awaiting requested review from larsoner larsoner is a code owner

@agramfort agramfort Awaiting requested review from agramfort agramfort is a code owner

@dengemann dengemann Awaiting requested review from dengemann dengemann is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@harrisonritz @drammock @larsoner