MAINT: Use radius keyword with PyVista tube #13277
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
|
@user27182 do you have a name + URL you'd like to have associated with your fix? I can push a quick changelog update for you |
|
(see https://mne.tools/dev/changes/devel.html for how it would render with a given contributor's name linking to a URL of their choice) |
|
Thanks @larsoner . This is such a small change, I'm not sure if it's necessary to be logged... but you can point to https://github.com/user27182 with name user27182 if this log is required |
larsoner
left a comment
larsoner
left a comment
There was a problem hiding this comment.
Pushed a changelog entry for completeness and marking for merge-when-green, thanks in advance @user27182 !
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
* upstream/main: (55 commits) doc: fix rendering typo rst docstr (mne-tools#13301) DOC: fix docstrs around layout functions (mne-tools#13300) MAINT: Fix doc build failure due to deprecation (mne-tools#13299) Birthday input cast to datetime.date (mne-tools#13284) DOC: fix missing space, use f-strings, structure->object (mne-tools#13291) [pre-commit.ci] pre-commit autoupdate (mne-tools#13290) ENH: channel_indices_by_type now has an exclude param (mne-tools#13293) Proj id and proj name access (mne-tools#13261) Fix: nearly invisible traces with spatial_colors=True (mne-tools#13286) [pre-commit.ci] pre-commit autoupdate (mne-tools#13283) Bump autofix-ci/action from 551dded8c6cc8a1054039c8bc0b8b48c51dfc6ef to 635ffb0c9798bd160680f18fd73371e355b85f27 in the actions group (mne-tools#13282) fix Maxwell bads filtering (mne-tools#13280) fix actionable linkcheck errors (mne-tools#13273) MAINT: Use radius keyword with PyVista tube (mne-tools#13277) BUG: Fix bug with simulating head pos and BEM (mne-tools#13276) [pre-commit.ci] pre-commit autoupdate (mne-tools#13274) MAINT: Update code credit (mne-tools#13267) Annotations extras (mne-tools#13228) Tidy up the directory reading (mne-tools#13268) FIX, DOC: Drop bad channel in 10_publication_figure.py (mne-tools#13266) ...
2 participants
Reference issue
PyVista is deprecating most positional arguments as part of pyvista/pyvista#7581. It is better to use keywords explicitly.
What does this implement/fix?
This fixes a warning generated by the MNE Integration tests for the above PR as a result of a deprecation.