Skip to content

Conversation

@drammock
Copy link
Member

@drammock drammock commented Jun 2, 2025

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I typically push with [circle linkcheck] in the commit message just to see it come back green, worth doing once you take care of the "Other ones causing problems"... for those we should either change the URLs, remove/replace refs, or add to the ignore

doc/martinos.rst Outdated
Comment on lines 34 to 38
We encourage all Martinos center Python users to subscribe to the
`Martinos Python mailing list`_.
Martinos Python mailing list.

.. _Martinos Python mailing list: https://mail.nmr.mgh.harvard.edu/mailman/listinfo/martinos-python
.. 2025-06-02 link has been defunct for over a month
.. Martinos Python mailing list: https://mail.nmr.mgh.harvard.edu/mailman/listinfo/martinos-python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth just deleting the whole thing then?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth just deleting the whole thing then?

Maybe. IDK how widely read this page even is. Also, the entire Martinos mailman page is gone/moved (for all lists, not just the Python users one). maybe @jasmainak can track down the moved link, or confirm whether it's now dead or private?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems a bit weird actually to have specific instructions for any center nowadays. I say we remove it. If people want the old historical info they can get it in our old doc versions for a while.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I'll delete the entire page then

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote for removing it ... I'm sure it can be tracked down but I haven't seen anyone at Martinos really use the mailing list

@larsoner
Copy link
Member

larsoner commented Jun 4, 2025

You could just add an ignore for the README.md since we know it'll be fixed soon enough

@drammock drammock enabled auto-merge (squash) June 4, 2025 16:45
@drammock drammock merged commit 4033b3a into mne-tools:main Jun 4, 2025
32 checks passed
@drammock drammock deleted the linkcheck branch June 4, 2025 17:15
larsoner added a commit to larsoner/mne-python that referenced this pull request Jun 26, 2025
* upstream/main: (55 commits)
  doc: fix rendering typo rst docstr (mne-tools#13301)
  DOC: fix docstrs around layout functions (mne-tools#13300)
  MAINT: Fix doc build failure due to deprecation (mne-tools#13299)
  Birthday input cast to datetime.date (mne-tools#13284)
  DOC: fix missing space, use f-strings, structure->object (mne-tools#13291)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13290)
  ENH: channel_indices_by_type now has an exclude param (mne-tools#13293)
  Proj id and proj name access (mne-tools#13261)
  Fix: nearly invisible traces with spatial_colors=True (mne-tools#13286)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13283)
  Bump autofix-ci/action from 551dded8c6cc8a1054039c8bc0b8b48c51dfc6ef to 635ffb0c9798bd160680f18fd73371e355b85f27 in the actions group (mne-tools#13282)
  fix Maxwell bads filtering (mne-tools#13280)
  fix actionable linkcheck errors (mne-tools#13273)
  MAINT: Use radius keyword with PyVista tube (mne-tools#13277)
  BUG: Fix bug with simulating head pos and BEM (mne-tools#13276)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#13274)
  MAINT: Update code credit (mne-tools#13267)
  Annotations extras (mne-tools#13228)
  Tidy up the directory reading (mne-tools#13268)
  FIX, DOC: Drop bad channel in 10_publication_figure.py (mne-tools#13266)
  ...
zEdS15B3GCwq pushed a commit to zEdS15B3GCwq/mne-python that referenced this pull request Aug 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants