fixed warning message in set_channel_types() that caused KeyError whe… #2879
Conversation
…n unit_old was not a key in the _unit2human dict
|
this is a fix for #2878 |
mne/channels/channels.py
Outdated
| unit_new = _human2unit[ch_type] | ||
| if unit_old != _human2unit[ch_type]: | ||
| if unit_old in _human2unit.keys(): uo_str = _unit2human[unit_old] | ||
| else: uo_str = unit_old |
There was a problem hiding this comment.
please follow pep8 conventions. If the key is missing, please add it
There was a problem hiding this comment.
|
Style should be fixed, and I added the unknown unit to the dict as you suggested. However I'm not sure about this behavior: in the example I presented in #2878, the unit type is 0, and this code would result in a unit type of '0' (with value '0') being added to the dictionary. As another commenter on the issue mentioned, the underlying file reader might be the cause of the weird unit. I had simply intended to make the warning message not cause an error... |
|
what file reader did you use? |
|
look up FIFF constants |
|
We actually don't have a |
3 participants
…n unit_old was not a key in the _unit2human dict.