ENH : better error message when unit is not known #2955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Heh, I was just about to take this over |
Member
Author
|
you're too slow :)
|
Member
|
LGTM, will merge once the CIs are happy. Now stop messing around, take over #2838, decide it's too much work to get right, and merge my "solution" :) |
Member
Author
|
ok boss ... On Fri, Feb 26, 2016 at 4:32 PM, Eric Larson notifications@github.com
|
mne/channels/channels.py
Outdated
| unit_old = self.info['chs'][c_ind]['unit'] | ||
| unit_new = _human2unit[ch_type] | ||
| if unit_old not in _unit2human: | ||
| raise ValueError("Channel '%s' has unknown unit (%s). Please fix" |
Member
|
(I'll push to your branch) |
Member
Author
|
thx merge when green |
larsoner
added a commit
that referenced
this pull request
Feb 26, 2016
ENH : better error message when unit is not known
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2878
closes #2879