[MRG] raw.plot_psd() with flat channel #3342
Conversation
|
aren't you supposed to mark such channels as bad? |
|
Right, but if you forget to mark them as bad mne should not break but rather help figure out what's wrong, hence I am suggesting to warn or raise an error. |
|
ok so I'll let you come up with a good way to do this :) |
|
ok :) raising an error now... |
|
LGTM any other opinion? |
|
I'm only wondering if this check should be made more generally for other plotting functions. I sometimes do something wrong and end up trying to plot nan ERPs. |
|
Perhaps, but that can be a follow-up PR. We probably want to use |
|
Seems ok to me, but let' make sure not to implement it too high-level, down-stream, maybe useful in many other locations. To be checked. |
|
@Eric89GXL @dengemann are you making suggestions for this PR or discussing a more general solution? |
|
Future PR for isfinite is fine |
christianbrodbeck
changed the title
* 'master' of git://github.com/mne-tools/mne-python: (48 commits) FIX: Flake fix pep8 [MRG] FIX Topographic plotting for KIT-UMD data (mne-tools#3349) QUICKFIX: logging test Error message for simulate evoked. (mne-tools#3372) Warnings for big bems. (mne-tools#3374) Add test for baseline correction. Use apply_baseline in read_evokeds. Makes (None, 0) the default value baseline in apply_baseline. [FIX] Adds apply_baseline to Evoked fix component inds in ica tutorial (mne-tools#3379) FIX: Xdawn with shuffled epochs (mne-tools#3373) FIX consistency: Epochs.load_data() should always return self (mne-tools#3376) MRG: Build relevant examples (mne-tools#3365) [MRG] set vmin, vmax after smoothing in plot_epochs_image (mne-tools#3360) [FIX] Attempt to fix circle. fixing a bg plotting bug for topo plots Modified test and tutorial. [MRG] convert surface using python. (mne-tools#3273) [MRG] raw.plot_psd() with flat channel (mne-tools#3342) ...
5 participants
Currently when running
raw.plot_psd()with data containing a dead channel an empty plot is created. Should the fix treat the dead channel like a normal channel or raise a warning or error?