[MRG] fix component inds in ica tutorial #3379
Conversation
|
Looks ok for me - the last ecg component doesn't look convincing to me, but I think it could be left as it is so that all |
Current coverage is 86.68%@@ master #3379 diff @@
==========================================
Files 335 335
Lines 57635 57635
Methods 0 0
Messages 0 0
Branches 8782 8782
==========================================
- Hits 49961 49959 -2
- Misses 5000 5001 +1
- Partials 2674 2675 +1
|
mmagnuski
changed the title
|
can you give a link to the rendered tutorial so we can see?
|
| # | ||
| # Let's take a closer look at three potential candidates for artifact-related | ||
| # components: IC 12, IC 15 and IC 21 | ||
| # Let's take a closer at properties of first three independent components |
There was a problem hiding this comment.
do they make any sense?
we should add the EEGLAB way of sorting the components by explained variance...
There was a problem hiding this comment.
These are not artifacts but other than that - they make sense. I was thinking about sorting by explained variance - that would be very useful!
|
Here is the link. |
|
great ! thanks @mmagnuski |
|
if you're bored this we, it would be neat to be able to click on a topo when doing plot_components in order to zoom on this one. it seems eeglab allows you to do this. |
|
Definitely not bored, but good idea, I will try it next week. :) |
| # now let's inspect properties of components 15 and 21 (cardiac activity): | ||
| ica.plot_properties(raw, picks=[15, 21], psd_args={'fmax': 35.}) | ||
| # we can also take a look at multiple different components at once: | ||
| ica.plot_properties(raw, picks=[1, 2], psd_args={'fmax': 35.}) |
There was a problem hiding this comment.
how did we call this parameter elsewhere in the ICA code btw.? I think not picks. We should check and open an issue if needed to fix it.
There was a problem hiding this comment.
plot_components, plot_sources and plot_overlay use picks
There was a problem hiding this comment.
Actually plot_sources uses picks for channels but all the other use picks for components.
There was a problem hiding this comment.
Ok then it's fine. I think I just thought of the exclude/include params
that we also have here.
On Sat, 2 Jul 2016 at 19:41, Mikolaj Magnuski notifications@github.com
wrote:
In tutorials/plot_artifacts_correction_ica.py
#3379 (comment):###############################################################################
-# now let's inspect properties of components 15 and 21 (cardiac activity):
-ica.plot_properties(raw, picks=[15, 21], psd_args={'fmax': 35.})
+# we can also take a look at multiple different components at once:
+ica.plot_properties(raw, picks=[1, 2], psd_args={'fmax': 35.})Actually plot_sources uses picks for channels but all the other use picks
for components.—
You are receiving this because you commented.Reply to this email directly, view it on GitHub
https://github.com/mne-tools/mne-python/pull/3379/files/3aca2028c67b50aadeb9aa6f4fe4341e6c109deb#r69381404,
or mute the thread
https://github.com/notifications/unsubscribe/AB0fitvAPd34uuJD1nxLJssSebvQQKwVks5qRrDrgaJpZM4JDjjM
.
* 'master' of git://github.com/mne-tools/mne-python: (48 commits) FIX: Flake fix pep8 [MRG] FIX Topographic plotting for KIT-UMD data (mne-tools#3349) QUICKFIX: logging test Error message for simulate evoked. (mne-tools#3372) Warnings for big bems. (mne-tools#3374) Add test for baseline correction. Use apply_baseline in read_evokeds. Makes (None, 0) the default value baseline in apply_baseline. [FIX] Adds apply_baseline to Evoked fix component inds in ica tutorial (mne-tools#3379) FIX: Xdawn with shuffled epochs (mne-tools#3373) FIX consistency: Epochs.load_data() should always return self (mne-tools#3376) MRG: Build relevant examples (mne-tools#3365) [MRG] set vmin, vmax after smoothing in plot_epochs_image (mne-tools#3360) [FIX] Attempt to fix circle. fixing a bg plotting bug for topo plots Modified test and tutorial. [MRG] convert surface using python. (mne-tools#3273) [MRG] raw.plot_psd() with flat channel (mne-tools#3342) ...
4 participants
This should work now.