MRG: Fix broken examples #5799
Merged
MRG: Fix broken examples #5799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
Dec 17, 2018
Contributor
|
Thx @larsoner. I did not realize that some examples broke. circle was passing. |
massich
approved these changes
Dec 17, 2018
Member
Author
CircleCI on PRs only runs examples that have been changed by the PR. If it ran all examples, each run would take 1.5 hours instead of 15 minutes. FYI if you know you might be breaking something, you can just tweak the examples you think might break somehow. There is always some tiny wording to fix. But when doing API stuff it's often not clear exactly what will break / which examples use functions, so it breaks from time to time, not a big problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few examples broken by #5741