MRG: Add reject_by_annotation to find_ecg_events #5895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
approved these changes
Jan 31, 2019
Codecov Report
@@ Coverage Diff @@
## master #5895 +/- ##
=========================================
+ Coverage 88.69% 88.7% +0.01%
=========================================
Files 396 396
Lines 71870 71938 +68
Branches 12071 12077 +6
=========================================
+ Hits 63742 63812 +70
+ Misses 5200 5199 -1
+ Partials 2928 2927 -1 |
Member
Author
|
@agramfort fixing the remaining CI bug made me find a few other bugs to fix. Can you look again to make sure you're still happy? |
agramfort
reviewed
Feb 4, 2019
agramfort
reviewed
Feb 4, 2019
agramfort
reviewed
Feb 4, 2019
Member
|
arfff ok. Can you maybe just add a comment to explain it?
… |
Member
Author
|
Done |
larsoner
force-pushed
the
find_ecg_events
branch
from
cbd72eb to
e35931a
Compare
agramfort
approved these changes
Feb 4, 2019
Member
Author
|
Travis error is unrelated and fixed by #5901 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reject_by_annotationtofind_ecg_events.reject_by_annotationvalue fromcreate_ecg_epochstofind_ecg_events(I consider it a bug that this wasn't done, given that it is done increate_eog_epochs->find_eog_events)._annotations_starts_stops(..., invert=True)to properly give contiguous segments