MRG+1: Keep annotations sorted #5900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5900 +/- ##
=========================================
- Coverage 88.7% 88.7% -0.01%
=========================================
Files 396 396
Lines 71938 71960 +22
Branches 12076 12082 +6
=========================================
+ Hits 63813 63832 +19
Misses 5199 5199
- Partials 2926 2929 +3 |
Member
|
LGTM but let's wait for @massich to come back from holidays to have a look. |
massich
approved these changes
Feb 11, 2019
Contributor
massich
left a comment
massich
left a comment
There was a problem hiding this comment.
All minor things, more a discussion than anything else.
Contributor
@larsoner comment on all (so that we can learn stuff), address what you think its meaningful and merge. |
Member
Author
|
Sorting simplifications implemented, will merge once CIs come back happy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5854.
Would be good to merge #5895 first, which contains some
Annotations-related tweaks and new tests.