MRG: fix issues raised by LGTM.com

[agramfort]

see https://lgtm.com/projects/g/mne-tools/mne-python/alerts/?mode=list

there are more...

there are quite some false positive but it's pretty efficient still.

[codecov]

Codecov Report

Merging #5914 into master will increase coverage by 0.01%.
The diff coverage is 84%.

@@            Coverage Diff             @@
##           master    #5914      +/-   ##
==========================================
+ Coverage   88.69%   88.71%   +0.01%     
==========================================
  Files         396      396              
  Lines       71998    71963      -35     
  Branches    12087    12078       -9     
==========================================
- Hits        63861    63839      -22     
+ Misses       5208     5199       -9     
+ Partials     2929     2925       -4

[larsoner]

I think that the analyses have started failing because I added externals to the skip list. Hopefully a merge will fix it. This is at least good enough incremental progress.

[larsoner]

This pull request introduces 5 alerts and fixes 106 when merging fd41864 into 63a8ce2 - view on LGTM.com

new alerts:

• 4 for __eq__ not overridden when adding attributes
• 1 for Module is imported with 'import' and 'import from'

fixed alerts:

• 35 for Unused local variable
• 32 for Module is imported with 'import' and 'import from'
• 9 for Unused named argument in formatting call
• 7 for Encoding error
• 3 for Redundant assignment
• 2 for Module is imported more than once
• 2 for Syntax error
• 2 for Inconsistent equality and hashing
• 2 for Result of integer division may be truncated
• 2 for Unused exception object
• 2 for Property in old-style class
• 1 for Wrong name for an argument in a call
• 1 for Unused import
• 1 for Raising a tuple
• 1 for List comprehension variable used in enclosing scope
• 1 for Unreachable code
• 1 for Suspicious unused loop iteration variable
• 1 for Variable defined multiple times
• 1 for Wrong number of arguments in a call

---

Comment posted by LGTM.com

[agramfort]

want me to do it?

…

[larsoner]

No I did it and it wasn't as annoying as I thought it would be :)

[massich]

ok I'm on the party too. How can I help :)

[agramfort]

LGTM ! :)

[larsoner]

@massich this one is done, #5900 is more interesting and needs merge

[larsoner]

This pull request introduces 6 alerts and fixes 106 when merging 28bfc34 into 6fdfb41 - view on LGTM.com

new alerts:

• 4 for __eq__ not overridden when adding attributes
• 2 for Module is imported with 'import' and 'import from'

fixed alerts:

• 35 for Unused local variable
• 32 for Module is imported with 'import' and 'import from'
• 9 for Unused named argument in formatting call
• 7 for Encoding error
• 3 for Redundant assignment
• 2 for Module is imported more than once
• 2 for Syntax error
• 2 for Inconsistent equality and hashing
• 2 for Result of integer division may be truncated
• 2 for Unused exception object
• 2 for Property in old-style class
• 1 for Wrong name for an argument in a call
• 1 for Unused import
• 1 for Raising a tuple
• 1 for List comprehension variable used in enclosing scope
• 1 for Unreachable code
• 1 for Suspicious unused loop iteration variable
• 1 for Variable defined multiple times
• 1 for Wrong number of arguments in a call

---

Comment posted by LGTM.com

[larsoner]

LGTM seems to have ignored our ignores, but we can live with the 6 warnings for now. I'm hoping merging will fix their parsing bug.

[agramfort]

Thx

[massich]

great!! now we can start bugging people in making LGTM green :)