-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
WIP: Add VisPy 3d backend #5925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add VisPy 3d backend #5925
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5925 +/- ##
==========================================
+ Coverage 89.26% 89.28% +0.01%
==========================================
Files 411 412 +1
Lines 74691 74966 +275
Branches 12341 12390 +49
==========================================
+ Hits 66676 66930 +254
- Misses 5151 5156 +5
- Partials 2864 2880 +16 |
|
This pull request introduces 1 alert when merging 7fdceda into 7856133 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
@GuillaumeFavelier you'll need to update the CIs script to start testing vispy. I would see if you can update one travis build so it uses vispy |
|
I would just update |
|
This pull request introduces 1 alert when merging 2a4b50b into 5a0bbee - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging 18d355c into 8b00fc9 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging e122460 into 8b00fc9 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging 8c96428 into b535a53 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging 1ff3d15 into 5537ba2 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
ToDo list:
After the rework on the quiver3d, text and the isolines this is the current result: With Mayavi (default): With VisPy (work in progress): |
|
About the shading of the spheres, I can use |
|
This pull request introduces 1 alert when merging d7ec52b into 0990196 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging 46b4565 into 7c21bd6 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging 2361e47 into 571a792 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging e0a8894 into 925423c - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging a1f12ce into 297422c - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging b3db935 into c4a83c5 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging af8bb0b into 5d80e26 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging f28c21d into 5d80e26 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging 3904d70 into f26d816 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging d2ba8c2 into 5803738 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
This pull request introduces 1 alert when merging 4a6d73a into 62c0af8 - view on LGTM.com new alerts:
Comment posted by LGTM.com |
|
@GuillaumeFavelier what are the blockers / todos here? Do we still want this backend? |
|
I would say pause and let's focus on a light vtk backend that also
works with vtk-js in a notebook
… |




What does this implement/fix?
The goal of this PR is to add a VisPy-based 3d backend to the visualization capabilitites of MNE.
Additional information
It is a work in progress, some features are still missing or incomplete as of now.