Skip to content

Conversation

@GuillaumeFavelier
Copy link
Contributor

As we discussed @larsoner, this PR adds two tables to have an overview of the capabilitiies of each 3d backend available.

As of now, only Mayavi and PyVista are available but work is in progress to add VisPy and Ipyvolume too.

The first table contains all the 3D features supported by the backend and show the level of progression towards a full integration of those features into mne-python.

The second table is a list of the 3D functions currently supported and tested for this backend.

Those tables will be updated as more features will be added and the integration of the backend will improve. As expected, each new backend will add a column to those tables and once enough features are available, the PR for the "candidate" backend could be merged eventually.

For now, the convention used is 'X' for full support, '-' for partial support and ' ' (space) for not supported.

Of course, any suggestion to improve or any feedback is welcome.

@codecov
Copy link

codecov bot commented May 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b9b2c68). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #6370   +/-   ##
=========================================
  Coverage          ?   89.31%           
=========================================
  Files             ?      405           
  Lines             ?    74271           
  Branches          ?    12297           
=========================================
  Hits              ?    66335           
  Misses            ?     5072           
  Partials          ?     2864

@larsoner
Copy link
Member

Pushed a cosmit to clean up the table render

@larsoner
Copy link
Member

@larsoner larsoner merged commit 62c0af8 into mne-tools:master May 23, 2019
@larsoner
Copy link
Member

Feel free to rebase whichever backend you think is sufficiently mergeable and add to the table

@GuillaumeFavelier GuillaumeFavelier deleted the backend_3d_table branch May 24, 2019 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants