-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
WIP: Add Ipyvolume 3d backend #6232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add Ipyvolume 3d backend #6232
Conversation
…ier/mne-python into guillaume-ipyvolume-backend
…ier/mne-python into ipyvolume_backend
|
Thanks for the suggesting 1. and 2., I'll try those flags out right now. |
|
This pull request introduces 1 alert when merging 3ce92e0 into c2b9176 - view on LGTM.com new alerts:
|
|
Thanks for the refactoring @massich ! The recent modifications should fix the scenario 4. you had @larsoner (the |
|
This pull request introduces 4 alerts when merging 442f8b3 into f4b66b5 - view on LGTM.com new alerts:
|
|
@GuillaumeFavelier the rendering does not need to be perfect, just need to be able to see the three surfaces. Over in IPyvolume you show that even though it's not 100% correct you can see three overlaid meshes. Is that the case here now, too? |
|
With the latest version, even with The most satifying resut I got was inverting the processing order during depth test but this is a workaround that works only for this example: My next test is about the rendering order which could be another promising way to achieve a decent result. |
|
@GuillaumeFavelier what do you think we should do here? Abandon for now due to alpha limitations? |
|
yes leave it for later for now
|
|
Okay I'll close to clear up a bit of backlog |




What does this implement/fix?
The goal of this PR is to add a Ipyvolume-based 3d backend to the visualization capabilitites of MNE and inside a jupyter notebook in particular.
Additional information
It is a work in progress, some features are still missing or incomplete as of now.