Add brain functions table for overview #6515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
no need to reimplement 100% of the API of pysurfer. See what breaks in the
doc
build with pyvista and you'll see what people have actually a chance to use.
… |
Codecov Report
@@ Coverage Diff @@
## master #6515 +/- ##
==========================================
+ Coverage 87.91% 89.31% +1.39%
==========================================
Files 413 413
Lines 74602 74537 -65
Branches 12301 12292 -9
==========================================
+ Hits 65588 66569 +981
+ Misses 6178 5127 -1051
- Partials 2836 2841 +5 |
Contributor
Author
I agree with you @agramfort , we need only what's used of course.
I like the idea and this was also suggested by @larsoner in this comment I think. But as the refactor is not yet completed, would you be okay to start with this version of the table and refine it during the process? |
Member
|
sure as long as the objective is not to tick all boxes
… |
Contributor
Author
|
The objective is to tick the boxes we need. |
larsoner
reviewed
Jul 3, 2019
31 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #6460(comment) and adds a RST overview table from a functional point of view.
In my opinion, such a table improves visibility on the refactor/advancement of
mayavi-based features of theBrainobject.I put all the functions I could find as a first step but it may be more useful to resize to the subset of functions used in practice and prioritize the tasks maybe as an ordered TODO list. Any feedback is welcome.