MRG, FIX: Fix scalp coupling index test that intermittently failed #7319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was intermittently failing see mne-tools#7180 The test was assuming that random noise would be correlated less than 0.5, but sometimes by chance this happens.
Codecov Report
@@ Coverage Diff @@
## master #7319 +/- ##
==========================================
+ Coverage 89.88% 89.88% +<.01%
==========================================
Files 450 450
Lines 81243 81239 -4
Branches 12914 12914
==========================================
- Hits 73027 73024 -3
+ Misses 5395 5393 -2
- Partials 2821 2822 +1 |
agramfort
reviewed
Feb 14, 2020
larsoner
changed the title
Member
Author
|
Thanks @larsoner and @agramfort . I love going to bed and waking up to find someone else fixed my problems. The benefits of living upside down. |
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
…ne-tools#7319) * Remove scalp coupling index test that intermittently failed This test was intermittently failing see mne-tools#7180 The test was assuming that random noise would be correlated less than 0.5, but sometimes by chance this happens. * FIX: seed Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
…ne-tools#7319) * Remove scalp coupling index test that intermittently failed This test was intermittently failing see mne-tools#7180 The test was assuming that random noise would be correlated less than 0.5, but sometimes by chance this happens. * FIX: seed Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes issue raised in #7180 .
What does this implement/fix?
This test was intermittently failing see #7180
The test was assuming that random noise would be correlated less than 0.5, but sometimes by chance this happens.