Skip to content

MRG, DOC: update tutorial: epochs to pandas DataFrame #7180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 11 commits into from
Feb 14, 2020
Merged

MRG, DOC: update tutorial: epochs to pandas DataFrame #7180

larsoner merged 11 commits into from
Feb 14, 2020

Conversation

@drammock
Copy link
Member

@drammock drammock commented Jan 7, 2020 •
edited
Loading

WIP; requires #7206

@codecov
Copy link

codecov bot commented Feb 5, 2020 •
edited
Loading

Codecov Report

Merging #7180 into master will decrease coverage by 7.99%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #7180     +/-   ##
=========================================
- Coverage   89.88%   81.89%     -8%     
=========================================
  Files         450      450             
  Lines       81243    81243             
  Branches    12914    12914             
=========================================
- Hits        73027    66535   -6492     
- Misses       5395    12155   +6760     
+ Partials     2821     2553    -268

@drammock drammock mentioned this pull request Feb 10, 2020
Merged
7 tasks
@drammock drammock force-pushed the tut-epochs-to-pandas branch from 1035543 to 844355f Compare February 13, 2020 22:22
@drammock drammock marked this pull request as ready for review February 14, 2020 02:12
@drammock drammock changed the title Tutorial update: epochs to pandas DataFrame MRG, DOC: update tutorial: epochs to pandas DataFrame Feb 14, 2020
@drammock
Copy link
Member Author

drammock commented Feb 14, 2020

@larsoner @rob-luke I'm seeing a Travis failure here for nirx / scalp_coupling_index on a PR that only changes tutorials / docs.

@agramfort @dengemann since Travis fail is unrelated, this should be ready for review.

@drammock
Copy link
Member Author

drammock commented Feb 14, 2020

Here's the rendered tutorial link: https://17982-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/epochs/plot_40_epochs_to_data_frame.html#sphx-glr-auto-tutorials-epochs-plot-40-epochs-to-data-frame-py

@rob-luke
Copy link
Member

rob-luke commented Feb 14, 2020

Yep that's due to a bad test that I added. I thought this might happen and listed the issue here...

https://github.com/mne-tools/mne-python/blob/master/mne/preprocessing/tests/test_scalp_coupling_index.py#L53

I will remove this test in another PR.

rob-luke added a commit to rob-luke/mne-python that referenced this pull request Feb 14, 2020
@rob-luke
Remove scalp coupling index test that intermittently failed
2d73874 
This test was intermittently failing see mne-tools#7180 
The test was assuming that random noise would be correlated less than 0.5, but sometimes by chance this happens.
@rob-luke rob-luke mentioned this pull request Feb 14, 2020
Merged
@agramfort
Copy link
Member

agramfort commented Feb 14, 2020

looks great https://17982-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/epochs/plot_40_epochs_to_data_frame.html#sphx-glr-auto-tutorials-epochs-plot-40-epochs-to-data-frame-py

larsoner added a commit that referenced this pull request Feb 14, 2020
@rob-luke @larsoner
MRG, FIX: Fix scalp coupling index test that intermittently failed (#…
5152d60 
…7319)

* Remove scalp coupling index test that intermittently failed

This test was intermittently failing see #7180 
The test was assuming that random noise would be correlated less than 0.5, but sometimes by chance this happens.

* FIX: seed

Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
@larsoner
Copy link
Member

larsoner commented Feb 14, 2020

This will fix one of the three failures in master, can you see if you can add fixes for the other two here, too?

https://circleci.com/gh/mne-tools/mne-python/17989

@drammock
Copy link
Member Author

drammock commented Feb 14, 2020

@larsoner The tutorial build issues are fixed. The Azure failures for full-pip are all about TraitTuple deprecation, which is being dealt with in #7322. Just waiting on Travis.

@larsoner
Copy link
Member

larsoner commented Feb 14, 2020

I'll get this in to hopefully get back to green, thanks @drammock

@larsoner larsoner merged commit 9f3b76f into mne-tools:master Feb 14, 2020
@drammock drammock deleted the tut-epochs-to-pandas branch February 14, 2020 21:33
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
@rob-luke @larsoner @AdoNunes
MRG, FIX: Fix scalp coupling index test that intermittently failed (m…
c20db27 
…ne-tools#7319)

* Remove scalp coupling index test that intermittently failed

This test was intermittently failing see mne-tools#7180 
The test was assuming that random noise would be correlated less than 0.5, but sometimes by chance this happens.

* FIX: seed

Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
@drammock @AdoNunes
MRG, DOC: update tutorial: epochs to pandas DataFrame (mne-tools#7180)
002c040 
* rename file for explicit sorting

* WIP tutorial overhaul [ci skip]

* another example [ci skip]

* update tutorial in line with PR 7206 [ci skip]

* add flashy final example

* add seaborn to circleci

* add seaborn to intersphinx mapping

* add headings; fix dataframe glimpses; remove cruft; change thumbnail

* fix one more dataframe output; smooth wording in a few places

* fix other tutorials using to_data_frame

* restore print statement
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
@rob-luke @larsoner @AdoNunes
MRG, FIX: Fix scalp coupling index test that intermittently failed (m…
1028732 
…ne-tools#7319)

* Remove scalp coupling index test that intermittently failed

This test was intermittently failing see mne-tools#7180 
The test was assuming that random noise would be correlated less than 0.5, but sometimes by chance this happens.

* FIX: seed

Co-authored-by: Eric Larson <larson.eric.d@gmail.com>
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
@drammock @AdoNunes
MRG, DOC: update tutorial: epochs to pandas DataFrame (mne-tools#7180)
c8f409b 
* rename file for explicit sorting

* WIP tutorial overhaul [ci skip]

* another example [ci skip]

* update tutorial in line with PR 7206 [ci skip]

* add flashy final example

* add seaborn to circleci

* add seaborn to intersphinx mapping

* add headings; fix dataframe glimpses; remove cruft; change thumbnail

* fix one more dataframe output; smooth wording in a few places

* fix other tutorials using to_data_frame

* restore print statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@drammock @rob-luke @agramfort @larsoner