Skip to content

Conversation

@GuillaumeFavelier
Copy link
Contributor

This PR tries to reproduce recent Travis failure on #7247:

DeprecationWarning: 'TraitTuple' trait handler has been deprecated. Use Tuple instead.

Reference:
https://travis-ci.org/mne-tools/mne-python/jobs/650433990?utm_medium=notification&utm_source=github_status

@GuillaumeFavelier GuillaumeFavelier self-assigned this Feb 14, 2020
@GuillaumeFavelier GuillaumeFavelier changed the title TST: Depracation warning: 'TraitTuple' TST: Deprecation warning: 'TraitTuple' Feb 14, 2020
@larsoner
Copy link
Member

I would simultaneously fix the bug in Mayavi by PR and add it to the list of ignores in conftest.py here so we don't trip over it while we wait for them to merge and release

@GuillaumeFavelier
Copy link
Contributor Author

Once it's confirmed here, I add it in conftest.

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #7322 into master will increase coverage by 0.65%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #7322      +/-   ##
==========================================
+ Coverage   89.23%   89.88%   +0.65%     
==========================================
  Files         450      450              
  Lines       80449    81244     +795     
  Branches    12912    12914       +2     
==========================================
+ Hits        71789    73028    +1239     
+ Misses       5896     5394     -502     
- Partials     2764     2822      +58

@GuillaumeFavelier
Copy link
Contributor Author

Another one now:

DeprecationWarning: The 'rich_compare' metadata has been deprecated.

@GuillaumeFavelier
Copy link
Contributor Author

I'm still trying to reproduce locally

@GuillaumeFavelier
Copy link
Contributor Author

I opened enthought/mayavi#895

@GuillaumeFavelier
Copy link
Contributor Author

GuillaumeFavelier commented Feb 14, 2020

I tested on the master branch of mayavi and the DeprecationWarning of rich_compare has been fixed already, just not released. I'll add it to conftest

@GuillaumeFavelier
Copy link
Contributor Author

Following your advice @larsoner I opened enthought/mayavi#896

@GuillaumeFavelier
Copy link
Contributor Author

🤞

@larsoner larsoner merged commit a43db57 into mne-tools:master Feb 14, 2020
@larsoner
Copy link
Member

Unrelated failure, thanks @GuillaumeFavelier

AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
* Trigger CIs

* Update conftest

* Update conftest
AdoNunes pushed a commit to AdoNunes/mne-python that referenced this pull request Apr 6, 2020
* Trigger CIs

* Update conftest

* Update conftest
@GuillaumeFavelier GuillaumeFavelier deleted the mayavi_trait_tuple branch June 11, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants