MAINT: Revert #7318 #7330
Closed
MAINT: Revert #7318 #7330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Seems to be about a minute and a half faster, based on just comparing a couple of runs. Let me know if you think this makes sense @GuillaumeFavelier |
Contributor
|
@larsoner you're totally right, depth peeling is disabled in the pyvista 3d backend but a posteriori which means that testing for depth peeling is still done and disabled only afterwards. There is another way to disable depth peeling without using |
Member
Author
|
Yes please do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #7318.
This will fail without the changes in #7325, but I at least want to see if the 3D viz tests run faster so we can avoid Travis timeouts.