WIP: Disable depth peeling with rcparams #7337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
reviewed
Feb 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #7337 +/- ##
==========================================
+ Coverage 89.71% 89.90% +0.18%
==========================================
Files 450 450
Lines 81353 82120 +767
Branches 12932 13186 +254
==========================================
+ Hits 72983 73827 +844
+ Misses 5519 5448 -71
+ Partials 2851 2845 -6 |
larsoner
approved these changes
Feb 18, 2020
Member
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Disable depth peeling with rcparams * Use contextmanager to disable depth peeling * Fix context manager
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
* Disable depth peeling with rcparams * Use contextmanager to disable depth peeling * Fix context manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up of #7330 (comment) and disables completely depth peeling in the pyvista 3d backend without doing any window testing.