Remove Tools menu in _TimeViewer #7361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7361 +/- ##
==========================================
- Coverage 89.96% 89.95% -0.01%
==========================================
Files 451 451
Lines 81846 81853 +7
Branches 12982 12985 +3
==========================================
+ Hits 73632 73633 +1
- Misses 5384 5388 +4
- Partials 2830 2832 +2 |
Contributor
Author
|
What do you think @agramfort, @larsoner ? |
Member
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
AdoNunes
pushed a commit
to AdoNunes/mne-python
that referenced
this pull request
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
Toolsmenu in the_TimeViewerinterface as suggested in #7247 (comment)The removed menu presented options for default picking in PyVista which are not compatible with #7247 and can be misleading (#7247 (comment) and #7247 (comment))
It's an item of #7162