MRG, FIX: Fix today #7582
Closed
MRG, FIX: Fix today #7582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Also I noticed that even though there is a birthday, @nbara any interest in trying to actually populate that dict? I don't have files to test with so I'm probably not the best one to implement it. You can see the entries that can go in here: |
Contributor
|
Ooof, I haven't used GDF files in ages! I don't have other files to test I'm afraid... As per your initial question, I don't remember checking that the birthday and age stuff was correct, I wouldn't have had any use for my data back then. |
Codecov Report
@@ Coverage Diff @@
## master #7582 +/- ##
==========================================
+ Coverage 90.05% 90.13% +0.07%
==========================================
Files 452 452
Lines 83035 82958 -77
Branches 13127 13110 -17
==========================================
- Hits 74780 74777 -3
+ Misses 5403 5349 -54
+ Partials 2852 2832 -20 |
Member
Author
|
Merged by rebase |
larsoner
added
backported
and removed
backport-candidate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue from the listserv.
@nbara have you checked to see if the birthday / age stuff actually gives correct values?
Needs #7581, then I'll rebase