MRG, FIX: Datetime call in gdf 2.x age calculation

[SveaMeyer13]

Reference issue

WIth regards to #7124 .

What does this implement/fix?

While importing a GDF 2.x file with

from mne import io
io.read_raw_gdf(fname, preload=True)

we encountered the following error:

Extracting EDF parameters from /home/svea/Desktop/mne_examples/sample_data/B0103T.gdf...
GDF file detected
Traceback (most recent call last):
  File "/home/svea/Desktop/mne_examples/online_linear_demo.py", line 17, in <module>
    raw = io.read_raw_gdf(raw_fname, preload=True)
  File "/home/svea/Desktop/mne_examples/venv/lib/python3.7/site-packages/mne/io/edf/edf.py", line 1327, in read_raw_gdf
    verbose=verbose)
  File "<decorator-gen-164>", line 21, in __init__
  File "/home/svea/Desktop/mne_examples/venv/lib/python3.7/site-packages/mne/io/edf/edf.py", line 189, in __init__
    exclude, preload)
  File "/home/svea/Desktop/mne_examples/venv/lib/python3.7/site-packages/mne/io/edf/edf.py", line 377, in _get_info
    edf_info, orig_units = _read_header(fname, exclude)
  File "/home/svea/Desktop/mne_examples/venv/lib/python3.7/site-packages/mne/io/edf/edf.py", line 366, in _read_header
    return _read_gdf_header(fname, exclude), None
  File "/home/svea/Desktop/mne_examples/venv/lib/python3.7/site-packages/mne/io/edf/edf.py", line 865, in _read_gdf_header
    today = datetime.today(tzinfo=timezone.utc)
TypeError: today() takes no keyword arguments

After closer investigation, we suspect that it was caused by the changes introduced by #7124 and released in v0.20.0.

As stated in the Python docs for datetime,
datetime.now(tz=timezone.utc) should be the syntactically correct functional equivalent.

To then make today and patient['birthday'] comparable, we add tzinfo to birthday (in line 860).

[codecov]

Codecov Report

Merging #7581 into master will decrease coverage by 0.08%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #7581      +/-   ##
==========================================
- Coverage   90.20%   90.12%   -0.09%     
==========================================
  Files         452      452              
  Lines       82104    82941     +837     
  Branches    13109    13110       +1     
==========================================
+ Hits        74064    74752     +688     
- Misses       5206     5356     +150     
+ Partials     2834     2833       -1     

[cbrnr]

#7582 duplicate?

[larsoner]

Indeed, @SveaMeyer13 can you see if #7582 also works? I slightly prefer that one since it includes a test

[larsoner]

@SveaMeyer13 actually, instead can you update latest.inc with an update about the bugfix (you can take the wording from my PR if you want -- plus change to your name and add yourself to names.inc if not there already) and we can merge this, then I can rebase my PR to get the test in

[SveaMeyer13]

Done!

[larsoner]

Name here and above need to match, it's what CircleCI complains about (search "warning" in the log and you'll see it)

https://app.circleci.com/pipelines/github/mne-tools/mne-python/897/workflows/179f9067-911b-4472-b7eb-20702ffa91f8/jobs/19252

And the broken link is visible here

https://19252-1301584-gh.circle-artifacts.com/0/dev/whats_new.html

[larsoner]

Thanks @SveaMeyer13 !