Skip to content

Conversation

@hoechenberger
Copy link
Member

What does this implement/fix?

Allow to specify a custom figure title when plotting Dipole locations via Dipole.plot_locations() or viz.plot_dipole_locations().

Allow to specify a custom figure title when plotting `Dipole` locations
via `Dipole.plot_locations()` or `viz.plot_dipole_locations()`.
@codecov
Copy link

codecov bot commented Apr 3, 2020

Codecov Report

Merging #7558 into master will decrease coverage by 0.08%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #7558      +/-   ##
==========================================
- Coverage   90.20%   90.12%   -0.09%     
==========================================
  Files         450      450              
  Lines       81891    82726     +835     
  Branches    13074    13075       +1     
==========================================
+ Hits        73873    74559     +686     
- Misses       5195     5344     +149     
  Partials     2823     2823              

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can't you do what you want with

plt.gcf().suptitle('')

after the plot?

matplotlib figures are easy to modify even after they have been displayed

Co-Authored-By: Alexandre Gramfort <alexandre.gramfort@m4x.org>
@hoechenberger
Copy link
Member Author

can't you do what you want with

plt.gcf().suptitle('')

after the plot?

matplotlib figures are easy to modify even after they have been displayed

Yes that would certainly be possible, however since many other viz functions already have title or window_title parameters to allow setting the titles, I thought it would be good to have similar support while Dipole plotting as well, for the sake of consistency (and, obviously, usability!)

@agramfort
Copy link
Member

agramfort commented Apr 3, 2020 via email

@hoechenberger
Copy link
Member Author

Can't you just update a existing test?

Done in c9e0cd9
Thx for pointing this out

@larsoner larsoner merged commit 59925bb into mne-tools:master Apr 4, 2020
@larsoner
Copy link
Member

larsoner commented Apr 4, 2020

Thanks @hoechenberger

@hoechenberger hoechenberger deleted the dip-title branch April 4, 2020 14:10
larsoner added a commit to larsoner/mne-python that referenced this pull request Apr 10, 2020
* upstream/master: (1522 commits)
  FIX: Show bug
  MRG, FIX: Datetime call in gdf 2.x age calculation (mne-tools#7581)
  DOC: Simplify Darwin installation (mne-tools#7584)
  MRG, ENH: Allow picking without preload (mne-tools#7507)
  DOC: Document anonymization better (mne-tools#7587)
  Rework _Brain show (mne-tools#7580)
  DOC: Fixes in tutorial (mne-tools#7579)
  ENH: muscle artifact detection (mne-tools#7407)
  MRG: Remove toolbars in PyVista plotter (mne-tools#7572)
  WIP: Deregister plotter from the figure list in close() (mne-tools#7573)
  MRG: Fix mouse wheel event in _TimeViewer (mne-tools#7563)
  FIX: Fix toggle all (mne-tools#7567)
  MRG, FIX: parallel n_jobs check (mne-tools#7566)
  Rename artifact detection to movement detection (mne-tools#7569)
  ENH: Update spelling check [ci skip] (mne-tools#7565)
  MRG, ENH: Dont require preload for raw resample (mne-tools#7508)
  MRG: Add interpolation for NIRS signals (mne-tools#7428)
  WIP: Add temporal derivative distribution repair algorithm (mne-tools#7556)
  DOC: fix link in docstr [skip ci] (mne-tools#7562)
  ENH: Custom figure title when plotting Dipole locations (mne-tools#7558)
  ...
larsoner added a commit to larsoner/mne-python that referenced this pull request Apr 25, 2023
* upstream/master: (1522 commits)
  FIX: Show bug
  MRG, FIX: Datetime call in gdf 2.x age calculation (mne-tools#7581)
  DOC: Simplify Darwin installation (mne-tools#7584)
  MRG, ENH: Allow picking without preload (mne-tools#7507)
  DOC: Document anonymization better (mne-tools#7587)
  Rework _Brain show (mne-tools#7580)
  DOC: Fixes in tutorial (mne-tools#7579)
  ENH: muscle artifact detection (mne-tools#7407)
  MRG: Remove toolbars in PyVista plotter (mne-tools#7572)
  WIP: Deregister plotter from the figure list in close() (mne-tools#7573)
  MRG: Fix mouse wheel event in _TimeViewer (mne-tools#7563)
  FIX: Fix toggle all (mne-tools#7567)
  MRG, FIX: parallel n_jobs check (mne-tools#7566)
  Rename artifact detection to movement detection (mne-tools#7569)
  ENH: Update spelling check [ci skip] (mne-tools#7565)
  MRG, ENH: Dont require preload for raw resample (mne-tools#7508)
  MRG: Add interpolation for NIRS signals (mne-tools#7428)
  WIP: Add temporal derivative distribution repair algorithm (mne-tools#7556)
  DOC: fix link in docstr [skip ci] (mne-tools#7562)
  ENH: Custom figure title when plotting Dipole locations (mne-tools#7558)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants