MRG: Fix mouse wheel event in _TimeViewer #7563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@GuillaumeFavelier Doesn't fix things for me… |
GuillaumeFavelier
changed the title
Contributor
Author
|
Thanks for reporting. I will try something else. |
Codecov Report
@@ Coverage Diff @@
## master #7563 +/- ##
=======================================
Coverage 90.12% 90.13%
=======================================
Files 452 452
Lines 82800 82876 +76
Branches 13083 13101 +18
=======================================
+ Hits 74626 74697 +71
- Misses 5349 5350 +1
- Partials 2825 2829 +4 |
Contributor
Author
|
I improved the button press logic. How is it now? |
Member
|
@hoechenberger I let you do the first feedback / pass on @GuillaumeFavelier 's PRs ok for you? |
Member
|
@GuillaumeFavelier I have to apologize, I tested again and 30d44ea does already fix it for me!! I'm not sure what happened when I tried this out yesterday, maybe I forgot to reload mne / restart my Python interpreter after switching branches… But yes, you already fixed it yesterday :S |
Contributor
Author
|
Let's go back on 30d44ea then 👍 |
This reverts commit df58d83.
GuillaumeFavelier
changed the title
larsoner
pushed a commit
that referenced
this pull request
Apr 7, 2020
* Fix mouse wheel exploit * Improve mouse button check * Revert "Improve mouse button check" This reverts commit df58d83.
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Apr 10, 2020
* upstream/master: (1522 commits) FIX: Show bug MRG, FIX: Datetime call in gdf 2.x age calculation (mne-tools#7581) DOC: Simplify Darwin installation (mne-tools#7584) MRG, ENH: Allow picking without preload (mne-tools#7507) DOC: Document anonymization better (mne-tools#7587) Rework _Brain show (mne-tools#7580) DOC: Fixes in tutorial (mne-tools#7579) ENH: muscle artifact detection (mne-tools#7407) MRG: Remove toolbars in PyVista plotter (mne-tools#7572) WIP: Deregister plotter from the figure list in close() (mne-tools#7573) MRG: Fix mouse wheel event in _TimeViewer (mne-tools#7563) FIX: Fix toggle all (mne-tools#7567) MRG, FIX: parallel n_jobs check (mne-tools#7566) Rename artifact detection to movement detection (mne-tools#7569) ENH: Update spelling check [ci skip] (mne-tools#7565) MRG, ENH: Dont require preload for raw resample (mne-tools#7508) MRG: Add interpolation for NIRS signals (mne-tools#7428) WIP: Add temporal derivative distribution repair algorithm (mne-tools#7556) DOC: fix link in docstr [skip ci] (mne-tools#7562) ENH: Custom figure title when plotting Dipole locations (mne-tools#7558) ...
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
Apr 25, 2023
* upstream/master: (1522 commits) FIX: Show bug MRG, FIX: Datetime call in gdf 2.x age calculation (mne-tools#7581) DOC: Simplify Darwin installation (mne-tools#7584) MRG, ENH: Allow picking without preload (mne-tools#7507) DOC: Document anonymization better (mne-tools#7587) Rework _Brain show (mne-tools#7580) DOC: Fixes in tutorial (mne-tools#7579) ENH: muscle artifact detection (mne-tools#7407) MRG: Remove toolbars in PyVista plotter (mne-tools#7572) WIP: Deregister plotter from the figure list in close() (mne-tools#7573) MRG: Fix mouse wheel event in _TimeViewer (mne-tools#7563) FIX: Fix toggle all (mne-tools#7567) MRG, FIX: parallel n_jobs check (mne-tools#7566) Rename artifact detection to movement detection (mne-tools#7569) ENH: Update spelling check [ci skip] (mne-tools#7565) MRG, ENH: Dont require preload for raw resample (mne-tools#7508) MRG: Add interpolation for NIRS signals (mne-tools#7428) WIP: Add temporal derivative distribution repair algorithm (mne-tools#7556) DOC: fix link in docstr [skip ci] (mne-tools#7562) ENH: Custom figure title when plotting Dipole locations (mne-tools#7558) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with picking in
_TimeViewerwhen the mouse wheel event is the first mouse button interaction.Closes #7534