MRG: TimeViewer save movie

[GuillaumeFavelier]

This PR brings back the part of #7257 about save_movie in _TimeViewer. The default shortcut is CTRL+SHIFT+s and a new icon in the tool bar has been added:

[codecov]

Codecov Report

Merging #7612 into master will decrease coverage by 0.13%.
The diff coverage is 25.00%.

@@            Coverage Diff             @@
##           master    #7612      +/-   ##
==========================================
- Coverage   90.12%   89.99%   -0.14%     
==========================================
  Files         454      454              
  Lines       83401    83457      +56     
  Branches    13209    13212       +3     
==========================================
- Hits        75169    75108      -61     
- Misses       5373     5468      +95     
- Partials     2859     2881      +22     

[GuillaumeFavelier]

What do you think @agramfort, @hoechenberger , @larsoner?

[hoechenberger]

Thanks @GuillaumeFavelier, will test this ASAP.

Wondering if an even better icon could be:

(from https://material.io/resources/icons/?search=video&icon=video_call&style=outline)

WDYT? Any preferences there?

[GuillaumeFavelier]

No strong opinion here. Both does the job. I can change it.

[larsoner]

Slight preference for something that implies save (usually meaning: have a floppy disk), like

https://findicons.com/icon/163988/film_save

[GuillaumeFavelier]

Slight preference for something that implies save

Hm... This is a good point. It's about save_movie after all

[larsoner]

Bonus points if you can find (or make) an image for "screenshot" with the same floppy disk image superimposed in the same location of the icon, so that we have some icon-consistency for what will open a save dialog

[GuillaumeFavelier]

I tried to find something in the same style but I could not find anything so I made this one with Inkscape:

the same floppy disk image

With this one:

I will see how it goes when integrated in the tool bar

[GuillaumeFavelier]

I tried to find something in the same style but I could not find anything so I made this one with Inkscape:

I should probably increase the resolution of the icons. On my display, it's super small. You cannot notice the disk:

[GuillaumeFavelier]

@larsoner is it okay for you if I rework the icons (icon-consistency, resolution) in another PR just after #7606? I can open an issue to keep track of this.

[hoechenberger]

floppy disk image

Do people these days even know WTH a floppy disk is? I'm being serious, if you turn 20 this year, chances are you never ever had to deal with floppies in your entire life. And I haven't seen such a "Save" icon in … ages, either? Only in old or open-source software ;) On the Mac, these days you always have some autosave or use the File / Save (as) menu entry.

This just to say that I'm not against a floppy disk symbol, I just doubt it carries any useful meaning these days unless you're, like, in your 40s or older.

[hoechenberger]

Also wonder if it shouldn't be called "Capture Movie" or "Record Movie" or "Record Clip" instead of "Save Movie". Apple simply uses "Record" (without any further noun) in their Screencast app, as opposed to "Capture", which is used for still screenshots.

[larsoner]

Do people these days even know WTH a floppy disk is?

No, just like people might have no idea why you say "roll down the window" in a car. But the command still works, people still understand the meaning, and almost exclusively talk about it in these terms (at least in the US). They will still understand the icon's affordance. For example, this is what you see when you google "save icon":

So I imagine most people, young or old, will understand it.

Apple simply uses "Record" (without any further noun) in their Screencast app

Recording is typically done under interaction/continuous circumstances. So to me it's a different interaction mode than save movie, which is "start this from the beginning, play it, and save it to disk" (but really could do all of this in principle hiding it from the user). You could imagine at some point in the future we'd actually want a "record" feature where we do start recording by taking screenshots, but not changing anything, and allow the user to press buttons or do whatever they want, until they hit stop, then it saves. We definitely shouldn't do this now, just saying that "record" is probably not the right terminology to be thinking about here.

[hoechenberger]

@larsoner Thanks for this extensive response! You convinced me, and I trust you there regarding language use. So – "Save Movie"? + a small floppy icon? :)

[GuillaumeFavelier]

Useful material for the recording feature can be found in #7257 (comment)

[larsoner]

is it okay for you if I rework the icons (icon-consistency, resolution) in another PR just after #7606? I can open an issue to keep track of this.

Yeah you can just add it to the big tracking issue

So – "Save Movie"? + a small floppy icon? :)

I trust @GuillaumeFavelier to come up with something amazing at some point :)

[larsoner]

Thanks @GuillaumeFavelier !

[hoechenberger]

@GuillaumeFavelier @larsoner Just a thought, if it's difficult to find a good solution with "icon indicating movie plus small icon suggesting save": it just occurred to me that the "film save" icon @larsoner posted above:

actually would probably already carry the desired meaning even without the floppy disk. Because this … how do you even call this? "film reel snippet" suggests that something has been or will be stored permanently.

Now I don't really like this particular icon they provide on material.io:

BUT then I came across another idea, as this icon popped up:

A clapperboard! Couldn't that be a solution? Not sure how easy it is to identify this icon as a clapperboard – but if we modified it such that the… movable thing that claps down is lifted / tilted upwards, it could work, no?

[GuillaumeFavelier]

I like the last clapperboard icon!

I'll open a PR soon to experiment with icons with a better resolution and better consistency. I will link your suggestion for movie in the PR 👍