-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
FIX: Circle timeout after plot_visualize_stc #7634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Circle timeout after plot_visualize_stc #7634
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7634 +/- ##
==========================================
- Coverage 85.60% 85.59% -0.01%
==========================================
Files 454 454
Lines 83540 83539 -1
Branches 13218 13218
==========================================
- Hits 71512 71506 -6
- Misses 9314 9317 +3
- Partials 2714 2716 +2 |
|
@GuillaumeFavelier I think it's more likely a general memory problem. Sometimes it dies on And It's not the same as what happens on CircleCI, because Sphinx-gallery will close and GC at the end of each plotting block. And the SG report confirms this: https://mne.tools/dev/auto_tutorials/source-modeling/sg_execution_times.html Same on this PR, so maybe it does indeed fix it (?): In any case, this all indicates that the memory usage of |
|
So if I understand correctly you think that the failures on CircleCI are not related to memory but we should pay attention to it? I can open a PR about that and make it my priority. Using those 2 scripts as benchmarks. What do you think? |
Either that or somehow they are related to memory and this PR fixes it (?). I have no idea why they would, though. Also should we merge it? |
|
I am not sure myself. I wanted to investigate more actually:
|
|
Any way of getting more information really. |
|
I will push a hotfix for the missing slider too. |
|
This is now ready to merge @larsoner |
|
Thanks @GuillaumeFavelier ! |


I realized that since #7612 has been merged, Circle reaches timeout after
plot_visualize_stc. I can't reproduce locally so I decided to investigate in here._Brain.save_moviesave_moviereference cycle (waiting for CircleCI)UnboundLocalError:playback_speed_sliderused without being declared