Skip to content

Conversation

@sarasommariva
Copy link
Contributor

What does this implement/fix?

Added reference to package sesameeg into section install of the documentation.

@larsoner
Copy link
Member

I think we need a new page for this, see #5484. Would you be up for creating a new page? Then we can push commits with other packages and merge a first version of it, and others can add things later...

@agramfort
Copy link
Member

+1000

@drammock
Copy link
Member

I added that "related projects" section to the "pre-install" page in #6522. And @sarasommariva is adding sesameeg into that list, which is the correct place in my mind. @larsoner @agramfort what is the reasoning behind giving it a dedicated page? To me the pre-install page doesn't seem overly crowded or long...

@agramfort
Copy link
Member

agramfort commented May 27, 2020 via email

@larsoner
Copy link
Member

Ahh, forgot about that. Agreed it's not too long and we can live with it there for now at least.

@drammock drammock merged commit d1662c1 into mne-tools:master May 27, 2020
@drammock
Copy link
Member

thanks @sarasommariva

@sarasommariva
Copy link
Contributor Author

thanks to you all guys! I'll be happy to help with the plug-in page when/if needed.. for now I'm lazy enough to agree with @drammock :)

larsoner added a commit to larsoner/mne-python that referenced this pull request May 28, 2020
* upstream/master:
  MRG: Add support for foreground in _Brain (mne-tools#7843)
  MRG, MAINT: Change default role in conf.py (mne-tools#7841)
  MRG, ENH: Support n_col keyword in ica.plot_score (mne-tools#7825)
  add icons to source dist (mne-tools#7840)
  Add CZI to list of funders (mne-tools#7839)
  DOC: added reference to sesameeg package (mne-tools#7835)
  MRG, ENH: Automatically compute threshold for CTPS ECG detection (mne-tools#7819)
  MAINT: Show how picks work for planars (mne-tools#7833)
  Clearer info docstring (mne-tools#7832)
  MRG, ENH: Add estimation method legend (mne-tools#7830)
  Remove double spaces (mne-tools#7822)
  add troubleshooting message about OpenGL [skip travis] (mne-tools#7827)
  fix links [skip travis] (mne-tools#7826)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants