Add CZI to list of funders #7839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
It looks less abbreviated compared to the other entries: https://20314-1301584-gh.circle-artifacts.com/0/dev/index.html But maybe this just indicates that we should abbreviate the others less at some point. +1 for merge from me |
Member
Author
fair point. We could abbreviate inst. name to CZI, and/or use their initialism for this funding call (EOSS). Or, as you suggest, we could spell out "Department of Energy", "National Institutes of Health", etc. WDYT? |
Member
|
Up to you -- I would lean toward abbreviating both since that's what we do on the others now. But also feel free to try expanding the others (maybe just the funders is the way to go?) to see if it looks good |
agramfort
approved these changes
May 27, 2020
Member
|
Longer one LGTM, +1 for merge |
larsoner
added a commit
to larsoner/mne-python
that referenced
this pull request
May 28, 2020
* upstream/master: MRG: Add support for foreground in _Brain (mne-tools#7843) MRG, MAINT: Change default role in conf.py (mne-tools#7841) MRG, ENH: Support n_col keyword in ica.plot_score (mne-tools#7825) add icons to source dist (mne-tools#7840) Add CZI to list of funders (mne-tools#7839) DOC: added reference to sesameeg package (mne-tools#7835) MRG, ENH: Automatically compute threshold for CTPS ECG detection (mne-tools#7819) MAINT: Show how picks work for planars (mne-tools#7833) Clearer info docstring (mne-tools#7832) MRG, ENH: Add estimation method legend (mne-tools#7830) Remove double spaces (mne-tools#7822) add troubleshooting message about OpenGL [skip travis] (mne-tools#7827) fix links [skip travis] (mne-tools#7826)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.