MRG, BUG: Fix vector scaling #7934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug with glyph colormap not being updated, tested with:
Details
A few things along the way:
update_lutso that there is no longer a need for the very repeat-yupdate_fmin,update_fmid, andupdate_fmaxupdate_lutinstead of potentially multiple calls likeupdate_fminfollowed byupdate_fmidupdate_fscaleprivate (I don't think it was meant to be public)alphato the LUT, but instead apply it to themesh(..., opacity=alpha)instead.Approximately 3x minus-to-plus ratio on this PR suggesting that it's DRYing out our code. No test added because I'm not sure that there is a great way to test this. In theory if there were existing vector + TimeViewer tests it could be added there, but in a quick check I did not see any. @GuillaumeFavelier feel free to correct me if I'm wrong...