Skip to content

Conversation

@bloyl
Copy link
Contributor

@bloyl bloyl commented Jul 1, 2020

source_space._get_src_nn assumed a 1-1 mapping between stc.vertices and src.vertices which broke stc.project if stc was already restricted to a label or during the forward computation.

Closes #7932

@bloyl bloyl requested a review from larsoner July 1, 2020 03:05
@bloyl bloyl closed this Jul 4, 2020
@bloyl bloyl reopened this Jul 4, 2020
@bloyl bloyl changed the title Fix: Issue with stc.project after restricting to a label [MRG] fix Issue with stc.project after restricting to a label Jul 4, 2020
@larsoner larsoner merged commit 54b88d2 into mne-tools:master Jul 5, 2020
@larsoner
Copy link
Member

larsoner commented Jul 5, 2020

Thanks @bloyl

larsoner added a commit to larsoner/mne-python that referenced this pull request Jul 8, 2020
* upstream/master: (30 commits)
  MRG: Add remove_labels to _Brain (mne-tools#7964)
  Add get_picked_points (mne-tools#7963)
  ENH: Add OpenGL info to mne sys_info (mne-tools#7976)
  [MRG] Fix reject_tmin and reject_tmax for reject_by_annotation in mne.Epochs (mne-tools#7967)
  mrg: Add scalar mult and div operators for AverageTFR (mne-tools#7957)
  MRG, MAINT: Cleaner workaround for Sphinx linking issue (mne-tools#7970)
  MRG, ENH: Speed up epochs.copy (mne-tools#7968)
  MRG, BUG: Allow ref mags to have a comp grade (mne-tools#7965)
  do not forget to pass adjacency (mne-tools#7961)
  [MRG] fix Issue with stc.project after restricting to a label (mne-tools#7950)
  Only process nirx event file if present (mne-tools#7951)
  MRG+1: BUG: info['bads'] order shouldn't matter in write_evokeds() (mne-tools#7954)
  Fix some small glitches introduced via mne-tools#7845 (mne-tools#7952)
  Add time player (mne-tools#7940)
  MAINT: Clean up VTK9 offset array [circle front] (mne-tools#7953)
  MAINT: Skip a few more on macOS (mne-tools#7948)
  fix links [skip travis] (mne-tools#7949)
  MRG, MAINT: Tweak CIs (mne-tools#7943)
  MRG, BUG: Fix vector scaling (mne-tools#7934)
  MRG, VIZ, BUG: handle CSD channel type when topo plotting (mne-tools#7935)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

stc.project('pca', src) requires fwd['src']

3 participants