Skip to content

MRG: Add SSP projectors to Report #7991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larsoner merged 12 commits into from
Jul 14, 2020
Merged

MRG: Add SSP projectors to Report #7991

larsoner merged 12 commits into from
Jul 14, 2020

Conversation

@hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Jul 10, 2020

This is still WIP and depends on #7990. So will need to be rebased after #7990 has been merged.

@agramfort
Copy link
Member

agramfort commented Jul 10, 2020

can you share a rendered report to see how it looks?

@hoechenberger
Copy link
Member Author

hoechenberger commented Jul 10, 2020

can you share a rendered report to see how it looks?

Yes, once it renders :D

@hoechenberger hoechenberger changed the title WIP Add Raw SSP projectors to Report WIP Add SSP projectors to Report Jul 10, 2020
@hoechenberger hoechenberger marked this pull request as ready for review July 10, 2020 16:28
@hoechenberger hoechenberger changed the title WIP Add SSP projectors to Report Add SSP projectors to Report Jul 10, 2020
@hoechenberger hoechenberger requested a review from agramfort July 10, 2020 16:50
@hoechenberger
Copy link
Member Author

hoechenberger commented Jul 10, 2020

Built doc: https://21081-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/misc/plot_report.html#sphx-glr-auto-tutorials-misc-plot-report-py

See the 2nd Report in there for an example with SSP projectors.

@hoechenberger
Copy link
Member Author

hoechenberger commented Jul 10, 2020

built doc:
https://21097-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/misc/plot_report.html#sphx-glr-auto-tutorials-misc-plot-report-py

@hoechenberger hoechenberger mentioned this pull request Jul 11, 2020
Closed
8 tasks
@hoechenberger
Copy link
Member Author

hoechenberger commented Jul 11, 2020

@larsoner @GuillaumeFavelier Any idea why the notebook test is failing? Seems to be unrelated to this PR?

@agramfort
Copy link
Member

agramfort commented Jul 11, 2020

@hoechenberger projs are often stored in separate files like a cov.fif you have proj.fif. Cf sample data and study template that have projs for ecg and eog. Here you plot the projs in the data. Please add the other option with separate files.

@hoechenberger
Copy link
Member Author

hoechenberger commented Jul 11, 2020

Doc artifact:
https://21141-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/misc/plot_report.html#sphx-glr-auto-tutorials-misc-plot-report-py

@hoechenberger
Copy link
Member Author

hoechenberger commented Jul 11, 2020

re Travis error see #8000 (comment)

@hoechenberger hoechenberger mentioned this pull request Jul 12, 2020
Closed
agramfort
agramfort reviewed Jul 12, 2020
View reviewed changes
@hoechenberger
Copy link
Member Author

hoechenberger commented Jul 12, 2020

Travis errors seem unrelated. We need to fix this flake8 thing for Python 3.6…

@hoechenberger hoechenberger changed the title Add SSP projectors to Report MRG: Add SSP projectors to Report Jul 13, 2020
@hoechenberger
Copy link
Member Author

hoechenberger commented Jul 13, 2020

As far as I am concerned, this is good to merge.

larsoner
larsoner approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with or without the suggested change

@hoechenberger
Copy link
Member Author

hoechenberger commented Jul 14, 2020

I have no idea why the phsionet dataset test is failing on Travis, all dataset tests pass without any issues locally for me.

@larsoner larsoner merged commit 492afc2 into mne-tools:master Jul 14, 2020
@larsoner
Copy link
Member

larsoner commented Jul 14, 2020

Thanks @hoechenberger

@hoechenberger hoechenberger deleted the projs branch July 14, 2020 14:53
larsoner added a commit to larsoner/mne-python that referenced this pull request Jul 14, 2020
@larsoner
Merge remote-tracking branch 'upstream/master' into refactor
c1f79f7 
* upstream/master: (21 commits)
  MRG: Add SSP projectors to Report (mne-tools#7991)
  BUG: Fix warning (mne-tools#8006)
  WIP: TFR Doc/test changes (mne-tools#7998)
  MAINT: Remove numpydoc test on 3.6 (mne-tools#8005)
  MAINT: Better error message for mismatch (mne-tools#8007)
  MRG: Allow removal of active projectors if channels they applied to have meanwhile been dropped (mne-tools#8003)
  MRG Freesurfer coordinate frame tutorial (mne-tools#7578)
  FIX: Fix stockwell checks (mne-tools#7996)
  MRG, ENH: Add array-spacing plugin and reorganize deps (mne-tools#7997)
  MRG, ENH: Reduce memory usage of Welch PSD (mne-tools#7994)
  STY: One more [ci skip]
  STY: Docstyle [ci skip]
  Report parsing (mne-tools#7990)
  MRG, ENH: BrainVision impedance parsing (mne-tools#7974)
  BUG: Fix missing source space points (mne-tools#7988)
  [MRG] Strip base directory name from Report captions when using parse_folder (mne-tools#7986)
  DOC: Update estimates [skip travis] (mne-tools#7987)
  DOC: Try to improve find_bad_channels_maxwell doc (mne-tools#7982)
  VIZ, BUG: fix tickmarks in evoked topomap colorbar (mne-tools#7980)
  Add low-pass filter to find_bad_channels_maxwell() (mne-tools#7983)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larsoner larsoner larsoner approved these changes

@agramfort agramfort agramfort approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoechenberger @agramfort @larsoner