Skip to content

Conversation

@larsoner
Copy link
Member

Playing around with CIs a bit:

  1. Add flake8-array-spacing plugin. It allows us to remove some # noqa lines, which is nice. Not 100% sure we want this, but I want to see if it works at least.
  2. Remove pytest, flake8, and related things from the mne env and requirements.txt. Now these files only contain what is necessary to get 100% functionality out of MNE-Python.
  3. Create requirements_testing.txt and doc/requirements.txt with the additional requirements for running tests and building docs, respectively.

This simplifies our CI code a bit, which is nice. I'm not expecting the CIs to come back happy on the first try, but folks should feel free to have a look and see if they're happy with the overall structure for when I can get the CIs to cooperate.

Copy link
Member

@drammock drammock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes look reasonable. only thing I'm pondering is whether the filenaming is as clear as it could be, and the slight weirdness of having one of the requirements files under doc/

@larsoner
Copy link
Member Author

I went back and forth on the naming, too. But I figured having one under doc/ was better than another root-level file. But we don't have a better place for the _testing.txt one. I guess I could rename tools to testing...?

@drammock
Copy link
Member

I figured having one under doc/ was better than another root-level file.

A bloated root-level doesn't bother me, FWIW, as long as the filenames are well organized. requirements.txt, requirements_testing.txt, and requirements_docs.txt seems fine to me. I'd also change server_environment.yml to environment_server.yml or perhaps environment_headless.yml

@larsoner
Copy link
Member Author

I'd also change server_environment.yml to environment_server.yml or perhaps environment_headless.yml

Let's hold off on this one, I'm hoping that maybe we won't need it after pyvista/pyvista#824 (?)

@agramfort agramfort merged commit bab6cb3 into mne-tools:master Jul 11, 2020
@agramfort
Copy link
Member

thx @larsoner

we'll deal with notebook test failure next week

@larsoner larsoner deleted the array-spacing branch July 11, 2020 13:53
larsoner added a commit to larsoner/mne-python that referenced this pull request Jul 14, 2020
* upstream/master: (21 commits)
  MRG: Add SSP projectors to Report (mne-tools#7991)
  BUG: Fix warning (mne-tools#8006)
  WIP: TFR Doc/test changes (mne-tools#7998)
  MAINT: Remove numpydoc test on 3.6 (mne-tools#8005)
  MAINT: Better error message for mismatch (mne-tools#8007)
  MRG: Allow removal of active projectors if channels they applied to have meanwhile been dropped (mne-tools#8003)
  MRG Freesurfer coordinate frame tutorial (mne-tools#7578)
  FIX: Fix stockwell checks (mne-tools#7996)
  MRG, ENH: Add array-spacing plugin and reorganize deps (mne-tools#7997)
  MRG, ENH: Reduce memory usage of Welch PSD (mne-tools#7994)
  STY: One more [ci skip]
  STY: Docstyle [ci skip]
  Report parsing (mne-tools#7990)
  MRG, ENH: BrainVision impedance parsing (mne-tools#7974)
  BUG: Fix missing source space points (mne-tools#7988)
  [MRG] Strip base directory name from Report captions when using parse_folder (mne-tools#7986)
  DOC: Update estimates [skip travis] (mne-tools#7987)
  DOC: Try to improve find_bad_channels_maxwell doc (mne-tools#7982)
  VIZ, BUG: fix tickmarks in evoked topomap colorbar (mne-tools#7980)
  Add low-pass filter to find_bad_channels_maxwell() (mne-tools#7983)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants