-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG, ENH: Add array-spacing plugin and reorganize deps #7997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
drammock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes look reasonable. only thing I'm pondering is whether the filenaming is as clear as it could be, and the slight weirdness of having one of the requirements files under doc/
|
I went back and forth on the naming, too. But I figured having one under |
A bloated root-level doesn't bother me, FWIW, as long as the filenames are well organized. |
Let's hold off on this one, I'm hoping that maybe we won't need it after pyvista/pyvista#824 (?) |
|
thx @larsoner we'll deal with notebook test failure next week |
* upstream/master: (21 commits) MRG: Add SSP projectors to Report (mne-tools#7991) BUG: Fix warning (mne-tools#8006) WIP: TFR Doc/test changes (mne-tools#7998) MAINT: Remove numpydoc test on 3.6 (mne-tools#8005) MAINT: Better error message for mismatch (mne-tools#8007) MRG: Allow removal of active projectors if channels they applied to have meanwhile been dropped (mne-tools#8003) MRG Freesurfer coordinate frame tutorial (mne-tools#7578) FIX: Fix stockwell checks (mne-tools#7996) MRG, ENH: Add array-spacing plugin and reorganize deps (mne-tools#7997) MRG, ENH: Reduce memory usage of Welch PSD (mne-tools#7994) STY: One more [ci skip] STY: Docstyle [ci skip] Report parsing (mne-tools#7990) MRG, ENH: BrainVision impedance parsing (mne-tools#7974) BUG: Fix missing source space points (mne-tools#7988) [MRG] Strip base directory name from Report captions when using parse_folder (mne-tools#7986) DOC: Update estimates [skip travis] (mne-tools#7987) DOC: Try to improve find_bad_channels_maxwell doc (mne-tools#7982) VIZ, BUG: fix tickmarks in evoked topomap colorbar (mne-tools#7980) Add low-pass filter to find_bad_channels_maxwell() (mne-tools#7983) ...
Playing around with CIs a bit:
# noqalines, which is nice. Not 100% sure we want this, but I want to see if it works at least.pytest,flake8, and related things from themneenv andrequirements.txt. Now these files only contain what is necessary to get 100% functionality out of MNE-Python.requirements_testing.txtanddoc/requirements.txtwith the additional requirements for running tests and building docs, respectively.This simplifies our CI code a bit, which is nice. I'm not expecting the CIs to come back happy on the first try, but folks should feel free to have a look and see if they're happy with the overall structure for when I can get the CIs to cooperate.