-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG, ENH: Combine channels #8014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
acc56e5
Add method to combine channels
HanBnrd e0189a7
Use f-string in combine_channels
HanBnrd c7da640
Give the option to keep stim channel or not
HanBnrd a516617
Convert method into function
HanBnrd af3e80f
Create a single new instance
HanBnrd 64970b4
Add tests for combine_channels
HanBnrd f0e138a
Update changelog
HanBnrd b8cef04
Merge branch 'master' into combine-channels
HanBnrd 15c2fed
Fix pydocstyle
HanBnrd 780a978
Replace error by warning for single channels
HanBnrd 7eeebc7
Fix bug out of bounds due to stim and bad channels
HanBnrd 3b5241a
Add more tests
HanBnrd 0ead668
Add drop_bad parameter and use OrderedDict
HanBnrd 42511d5
Add missing tests
HanBnrd 200f3cc
Modify wording in docstring
HanBnrd 922d54d
Add combine_channels to python_reference.rst
HanBnrd 0fbe53d
Apply suggestions from code review
HanBnrd 6a77c7d
No copy for stim
HanBnrd e5e303f
Speed up tests with preload on Raw
HanBnrd 80b4bba
Add draft tutorial for combine_channels
HanBnrd aa864e3
Fix typo
HanBnrd 4a0a40d
Fix warning in doc
HanBnrd e520fbf
Merge remote-tracking branch 'upstream/master' into combine-channels
HanBnrd d001716
Modify ROIs for tutorial
HanBnrd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed this to be a warning instead of an error, as I though it might be better if one wants to use this function when iterating over many instances and for some reason one has no stim channels... It's more convenient probably.