Skip to content

Conversation

@larsoner
Copy link
Member

Testing on my Windows machine I found that some of the tolerances were too strict (minor linalg differences when reg=0 in beamformer or for gamma_map). Also I noticed that there were un-freed resources in test_what.py, which I think is causing this in master on Azure:

mne\io\tests\test_utils.py .                                             [ 41%]
##[error]Cmd.exe exited with code '-1073741819'.

This fixes it by being safer about fiff_open.

@larsoner larsoner changed the title MRG, MAINT: Cleaner resource use and test tols WIP, MAINT: Cleaner resource use and test tols Jul 23, 2020
@larsoner
Copy link
Member Author

Actually I think the Azure error is really numpy/numpy#16913. I'll do a full run here with -vvs just to confirm, but it does seem to be the case that a simple np.dot is the problem in this Azure run.

@larsoner larsoner changed the title WIP, MAINT: Cleaner resource use and test tols MRG, MAINT: Cleaner resource use and test tols Jul 23, 2020
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM provided CIs are green

@larsoner larsoner merged commit 3545c3f into mne-tools:master Jul 23, 2020
@larsoner larsoner deleted the tols branch July 23, 2020 21:38
@larsoner larsoner mentioned this pull request Jul 24, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants