Skip to content

Conversation

@GuillaumeFavelier
Copy link
Contributor

@GuillaumeFavelier GuillaumeFavelier commented Apr 9, 2021

On the latest version, the API for _add_observer() and use_ipyvtk have been modified. This PR tries to catch up to those changes. Changes are also necessary in PyVistaQt.

Follows #9010 (comment)

@GuillaumeFavelier
Copy link
Contributor Author

Updates on pyvistaqt and pyvista. I'm working on it.

@GuillaumeFavelier GuillaumeFavelier changed the title WIP,FIX: Prepare for PyVista 0.29+ WIP,FIX: Prepare for PyVista 0.30.0 Apr 12, 2021
python -m pip install --progress-bar off --upgrade --pre --only-binary ":all:" numba llvmlite
wget -q https://osf.io/kej3v/download -O vtk-9.0.20201117-cp39-cp39-linux_x86_64.whl
python -m pip install --progress-bar off vtk-9.0.20201117-cp39-cp39-linux_x86_64.whl
python -m pip install --progress-bar off https://github.com/pyvista/pyvista/zipball/master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sure, I'll use that then

@GuillaumeFavelier GuillaumeFavelier changed the title WIP,FIX: Prepare for PyVista 0.30.0 FIX: Prepare for PyVista 0.30.0 Apr 12, 2021
@GuillaumeFavelier
Copy link
Contributor Author

What do you think @larsoner ?

@larsoner larsoner merged commit 392d5ca into mne-tools:main Apr 12, 2021
@larsoner
Copy link
Member

Thanks @GuillaumeFavelier !

@GuillaumeFavelier GuillaumeFavelier deleted the patch/pyvista branch April 12, 2021 14:51
larsoner added a commit to agramfort/mne-python that referenced this pull request Apr 12, 2021
* upstream/main:
  MRG: Return empty list of SSP projectors if no ECG, EOG events were found (mne-tools#9277)
  Better warning message for EDF files with annotations only (mne-tools#9283)
  FIX: Link [ci skip]
  FIX: Prepare for PyVista 0.30.0 (mne-tools#9274)
  Use info for checking more NIRS metadata, not raw (mne-tools#9282)
  MRG: Use info for checking NIRS metadata, not raw (mne-tools#9280)
  Fix issue where set ylim parameter gets swapped across channel types in plot_evoked_topo (mne-tools#9207)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants