FIX: Prepare for PyVista 0.30.0 (part 2) #9291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mne/viz/_brain/_brain.py
Outdated
| # pyvista<=0.30.0 | ||
| self.plotter._key_press_event_callbacks.clear() | ||
| except AttributeError: | ||
| # pyvista>=0.30.0 |
Member
There was a problem hiding this comment.
== 0.30.0 will match both though?? 😅
Member
There was a problem hiding this comment.
should probably be 0.3.0 not 0.30.0
Contributor
Author
|
I think Circle does not want to install PyVistaQt master because |
Contributor
Author
|
I opened pyvista/pyvistaqt#97 (comment) |
GuillaumeFavelier
changed the title
Contributor
Author
|
Okay, with this we should (hopefully) be better prepared for |
Member
|
Pushed a tiny cosmit, thanks @GuillaumeFavelier ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the second wave of changes to adapt to PyVista 0.30.0 and PyVistaQt 0.3.0+
ToDo:
requirements.txtandenvironment.ymltopyvista/masteronce MNT: Add PIP pre job pyvista/pyvistaqt#95 is mergedFollows #9274
Related to pyvista/pyvista#1257