-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MRG, MAINT: Bump requirements, remove cruft #9358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| sphinx | ||
| https://github.com/numpy/numpydoc/archive/main.zip | ||
| pydata-sphinx-theme==0.6.1 | ||
| pydata-sphinx-theme>=0.6.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep this pinned. The theme is still under pretty active development, and its test suite is still being refined.
| pydata-sphinx-theme>=0.6.3 | |
| pydata-sphinx-theme==0.6.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed that was the original rationale, but I'm hoping that by doing this we can catch their bugs earlier, similar to how we build CircleCI with sphinx-gallery:master. I figure if it starts breaking things in a way we can't easily fix then we can easily add a fixed pin later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough. I guess staying on latest point release is not as dangerous as being on their latest main, anyway.
agramfort
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what a cleanup !
* upstream/main: FIX: make epoch cropping idempotent (mne-tools#9378) MRG, ENH: Add NIRSport support (mne-tools#9348) MRG, ENH: Make _get_hpi_info public (mne-tools#9369) ENH: Add a playback button to the notebook 3d backend (mne-tools#8741) better docs for permutation_cluster_test (mne-tools#9365) MRG: Add fNIRS to html output (mne-tools#9367) When plotting GFP comparison in Report, don't show sensor layout by default (mne-tools#9366) DOC: Update Mayavi troubleshooting section (mne-tools#9362) more tutorial tweaks (mne-tools#9359) MRG, MAINT: Use native GitHub Actions skip (mne-tools#9361) MAINT: Clean up crufty code [circle front] (mne-tools#9358) API: Complete deprecations (mne-tools#9356) Add qdarkstyle, darkdetect to environment.yml [circle full] (mne-tools#9357) FIX: Fix FIX: Add
fixes.pythat required old versions (np.einsum, np.take_along_axis, etc.)oldCI runviz/utils.pythat really belongs infixes.py, which is meant to keep version-specific backward compat shimsXXXandTODOin our codebase and took care of some of them, including:run_tests_as_main_TempDirin tests in most placesmorph_mapscode to their own file rather than living insurface.pyDigMontage.dev_head_tas it's never used or set, and probably was never meant to be there (we have a warning that this class should not be instantiated by users anyway)I'm going to update the "make a release" instructions with steps 1-3 since I think it should come right after the deprecations PR (as it is here).
@drammock I left a fun one behind that you can tackle in a follow-up PR in
mne/viz/_figure.py: