FIX: make epoch cropping idempotent #9378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽♂️ |
Member
|
The test failure seems unrelated. @jsosulski can you add a line in the bug fix section of our what’s new page? See file latest.inc Thx ! |
agramfort
approved these changes
May 7, 2021
Member
agramfort
left a comment
agramfort
left a comment
There was a problem hiding this comment.
thx @jsosulski that's perfect !
Member
|
@larsoner I let you merge when you have a minute ! |
Contributor
Author
|
@agramfort : I just finished checking all the |
Member
|
if you can fix everything in one PR it's great. All the fixes are related
… |
agramfort
approved these changes
May 9, 2021
Member
agramfort
left a comment
agramfort
left a comment
There was a problem hiding this comment.
thx @jsosulski
@larsoner ok with the fix?
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
Member
|
Thanks @jsosulski ! |
larsoner
added a commit
to agramfort/mne-python
that referenced
this pull request
May 10, 2021
* upstream/main: FIX: make epoch cropping idempotent (mne-tools#9378) MRG, ENH: Add NIRSport support (mne-tools#9348) MRG, ENH: Make _get_hpi_info public (mne-tools#9369) ENH: Add a playback button to the notebook 3d backend (mne-tools#8741) better docs for permutation_cluster_test (mne-tools#9365) MRG: Add fNIRS to html output (mne-tools#9367) When plotting GFP comparison in Report, don't show sensor layout by default (mne-tools#9366) DOC: Update Mayavi troubleshooting section (mne-tools#9362) more tutorial tweaks (mne-tools#9359) MRG, MAINT: Use native GitHub Actions skip (mne-tools#9361) MAINT: Clean up crufty code [circle front] (mne-tools#9358) API: Complete deprecations (mne-tools#9356) Add qdarkstyle, darkdetect to environment.yml [circle full] (mne-tools#9357) FIX: Fix FIX: Add
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Fixes #9374
What does this implement/fix?
Set
include_tmax=Truewhentmaxis larger than the epoch.Additional Information
I think this cannot be sensibly done in the
_time_maskfunction as we do not know whethertmaxwas set automatically or not in that function. However, I do now knot if_time_maskshould do this kind of error handling or if it is up to the calling functions.