WIP, MAINT: Fix CircleCI (again) #9814
Conversation
| report = mne.Report() | ||
| report.add_sys_info(title='System info') | ||
| report.save('report_sys_info.html', overwrite=True) |
There was a problem hiding this comment.
I'm not sure why this is problematic @hoechenberger but I'm inclined to remove it for now (merge this PR), then fix the bug in PyVista separately, then put this back in once it works properly. WDYT?
There was a problem hiding this comment.
Yes, let's remove this to allow us to move on. The lost test coverage will only be minimal, it's just a convenience method anyway that calls another one that is tested separately.
There was a problem hiding this comment.
And it will potentially save a few seconds of testing time
There was a problem hiding this comment.
Oh that's not a test, but the tutorial, sorry, I misread this. But yes it's okay to remove this. Please do what you think is necessary
|
Thanks @hoechenberger @agramfort @drammock for the quick feedback, hopefully we get a green Circle next! |
* upstream/main: MAINT: Update broken link, fix rendering (mne-tools#9829) Ensure plot_ica_sources() always plots traces of rejected ICs on top (mne-tools#9823) Improve plot_ica_sources() docstring (mne-tools#9825) MRG: Fix docstring for plot_ica_components() (mne-tools#9826) unpin jsonschema and filter its warning instead (mne-tools#9822) Add warning for SNIRF files with != 2 wavelengths (mne-tools#9817) add show_scalebars param to epochs.plot() (mne-tools#9815) MRG: Allow _plot_mri_contours() to return arrays (mne-tools#9818) MRG: Expand ~ in _check_fname() (mne-tools#9613) Improve ICA.plot_overlay() docstrings (mne-tools#9820) WIP, MAINT: Fix CircleCI (again) (mne-tools#9814) MRG, ENH: Add options to fit_dipole (mne-tools#9810) Rework Reports (new history) (mne-tools#9754) MRG, CI: Use VTK pre (mne-tools#9803)
3 participants
A smaller commit to isolate a potential problem.