Skip to content

Conversation

@drammock
Copy link
Member

This does the easy part of what #9821 was trying to do:

  • allows pip install mne[data] to automatically install dataset-fetching dependencies tqdm and pooch in addition to numpy and scipy

Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll need to update the doc and maybe some CI too no?

thx @drammock

@larsoner
Copy link
Member

you'll need to update the doc and maybe some CI too no?

Easiest might be to modify these lines:

- script: pip install -e .
displayName: 'Install MNE-Python dev'
- script: pip install --progress-bar off -r requirements_testing.txt -r requirements_testing_extra.txt codecov
condition: eq(variables['TEST_MODE'], 'conda')
displayName: Install testing requirements

To use a single pip install -e .[testing] codecov line or so

Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanups in there, too!

LGTM +1 for merge assuming CIs come back happy

@larsoner larsoner merged commit 9a474f5 into mne-tools:main Oct 13, 2021
@larsoner
Copy link
Member

Thanks @drammock

@drammock drammock deleted the easier-pip branch October 13, 2021 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants